linux-kernel - Re: [alsa-devel] [PATCH 2/4] ASoC: tegra: Add a TDM configuration callback

Open Source and information security mailing list archives

Message-ID: <20180730090441.GE28143@trinity.fluff.org>
Date:   Mon, 30 Jul 2018 10:04:42 +0100
From:   Ben Dooks <ben@...nity.fluff.org>
To:     Mark Brown <broonie@...nel.org>
Cc:     Jorge Sanjuan <jorge.sanjuan@...ethink.co.uk>,
        linux-kernel@...ts.codethink.co.uk, alsa-devel@...a-project.org,
        linux-kernel@...r.kernel.org, lgirdwood@...il.com,
        thierry.reding@...il.com, linux-tegra@...r.kernel.org,
        jonathanh@...dia.com
Subject: Re: [alsa-devel] [PATCH 2/4] ASoC: tegra: Add a TDM configuration
 callback

On Mon, Jul 30, 2018 at 09:49:08AM +0100, Mark Brown wrote:
> On Fri, Jul 27, 2018 at 01:59:29PM +0100, Jorge Sanjuan wrote:
> > From: Edward Cragg <edward.cragg@...ethink.co.uk>
> > 
> > Add a callback to configure TDM settings for the Tegra30
> > I2S ASoC 'platform' driver.
> > 
> > Signed-off-by: Ben Dooks <ben.dooks@...ethink.co.uk>
> > Signed-off-by: Edward Cragg <edward.cragg@...ethink.co.uk>
> 
> This says it was britten by Edward but there's a signoff from Ben before
> his?

Editing accdient, I was originally going to submit this series.

> > +	dev_dbg(dai->dev, "%s: setting TDM: tx_mask: 0x%08x rx_mask: 0x%08x"
> > +		"slots: 0x%08x width: %d\n",
> > +		__func__, tx_mask, rx_mask, slots, slot_width);
> 
> Please don't split log messages over lines, it makes it harder to grep
> for them.  Just use a long line.
> 
> I'm also not seeing any validation of the parameters?

> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@...a-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel

-- 
Ben Dooks, ben@...ff.org, http://www.fluff.org/ben/

Large Hadron Colada: A large Pina Colada that makes the universe disappear.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives