linux-kernel - Re: [PATCH] drm/mediatek: Convert drm_atomic_helper

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 30 Jul 2018 10:21:23 +0530
From:   Souptick Joarder <jrdr.linux@...il.com>
To:     CK Hu <ck.hu@...iatek.com>
Cc:     p.zabel@...gutronix.de, airlied@...ux.ie,
        Matthias Brugger <matthias.bgg@...il.com>,
        Ajit Linux <ajitn.linux@...il.com>,
        dri-devel@...ts.freedesktop.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/mediatek: Convert drm_atomic_helper_suspend/resume()

On Mon, Jul 30, 2018 at 9:23 AM, CK Hu <ck.hu@...iatek.com> wrote:
> Hi, Souptick:
>
> On Sat, 2018-07-28 at 19:08 +0530, Souptick Joarder wrote:
>> convert drm_atomic_helper_suspend/resume() to use
>> drm_mode_config_helper_suspend/resume().
>>
>
> Reviewed-by: CK Hu <ck.hu@...iatek.com>

Thank CK, can we get this patch in queue for 4.19 ?

>
>> Signed-off-by: Souptick Joarder <jrdr.linux@...il.com>
>> Signed-off-by: Ajit Negi <ajitn.linux@...il.com>
>> ---
>>  drivers/gpu/drm/mediatek/mtk_drm_drv.c | 21 ++++++++-------------
>>  1 file changed, 8 insertions(+), 13 deletions(-)
>>
>> diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
>> index a2ca90f..1fcda2de 100644
>> --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c
>> +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c
>> @@ -520,29 +520,24 @@ static int mtk_drm_sys_suspend(struct device *dev)
>>  {
>>       struct mtk_drm_private *private = dev_get_drvdata(dev);
>>       struct drm_device *drm = private->drm;
>> +     int ret;
>>
>> -     drm_kms_helper_poll_disable(drm);
>> -
>> -     private->suspend_state = drm_atomic_helper_suspend(drm);
>> -     if (IS_ERR(private->suspend_state)) {
>> -             drm_kms_helper_poll_enable(drm);
>> -             return PTR_ERR(private->suspend_state);
>> -     }
>> -
>> +     ret = drm_mode_config_helper_suspend(drm);
>>       DRM_DEBUG_DRIVER("mtk_drm_sys_suspend\n");
>> -     return 0;
>> +
>> +     return ret;
>>  }
>>
>>  static int mtk_drm_sys_resume(struct device *dev)
>>  {
>>       struct mtk_drm_private *private = dev_get_drvdata(dev);
>>       struct drm_device *drm = private->drm;
>> +     int ret;
>>
>> -     drm_atomic_helper_resume(drm, private->suspend_state);
>> -     drm_kms_helper_poll_enable(drm);
>> -
>> +     ret = drm_mode_config_helper_resume(drm);
>>       DRM_DEBUG_DRIVER("mtk_drm_sys_resume\n");
>> -     return 0;
>> +
>> +     return ret;
>>  }
>>  #endif
>>
>
>