linux-kernel - Re: [PATCH] mm: Remove zone_id() and make use of zone_idx() in is_dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48a3c91d-14cd-ec1a-dd9f-952cc5e3d5f7@suse.cz>
Date:   Mon, 30 Jul 2018 16:07:59 +0200
From:   Vlastimil Babka <vbabka@...e.cz>
To:     osalvador@...hadventures.net, akpm@...ux-foundation.org
Cc:     mhocko@...e.com, sfr@...b.auug.org.au, rientjes@...gle.com,
        pasha.tatashin@...cle.com, kemi.wang@...el.com,
        jia.he@...-semitech.com, ptesarik@...e.com,
        aryabinin@...tuozzo.com, linux-mm@...ck.org,
        linux-kernel@...r.kernel.org, dan.j.williams@...el.com,
        Oscar Salvador <osalvador@...e.de>
Subject: Re: [PATCH] mm: Remove zone_id() and make use of zone_idx() in
 is_dev_zone()

On 07/30/2018 03:37 PM, osalvador@...hadventures.net wrote:
> From: Oscar Salvador <osalvador@...e.de>
> 
> is_dev_zone() is using zone_id() to check if the zone is ZONE_DEVICE.
> zone_id() looks pretty much the same as zone_idx(), and while the use of
> zone_idx() is quite spread in the kernel, zone_id() is only being
> used by is_dev_zone().
> 
> This patch removes zone_id() and makes is_dev_zone() use zone_idx()
> to check the zone, so we do not have two things with the same
> functionality around.
> 
> Signed-off-by: Oscar Salvador <osalvador@...e.de>

Agreed.

Acked-by: Vlastimil Babka <vbabka@...e.cz>