linux-kernel - Re: [PATCH] mmc: tmio: remove unneeded variable in tmio_mmc_start

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFrbyiYhj_Q_hWCoxFG0pdg805ors9CuNm8Hb7Xh+2Wksg@mail.gmail.com>
Date:   Mon, 30 Jul 2018 17:06:51 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: tmio: remove unneeded variable in tmio_mmc_start_command()

On 25 July 2018 at 10:46, Masahiro Yamada <yamada.masahiro@...ionext.com> wrote:
> Pass TMIO_MASK_CMD to tmio_mmc_enable_mmc_irqs() directly,
> and remove the variable, irq_mask.
>
> Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>

Thanks, applied for next!

Kind regards
Uffe

> ---
>
>  drivers/mmc/host/tmio_mmc_core.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/mmc/host/tmio_mmc_core.c b/drivers/mmc/host/tmio_mmc_core.c
> index 3080299..3cb554c 100644
> --- a/drivers/mmc/host/tmio_mmc_core.c
> +++ b/drivers/mmc/host/tmio_mmc_core.c
> @@ -309,7 +309,6 @@ static int tmio_mmc_start_command(struct tmio_mmc_host *host,
>  {
>         struct mmc_data *data = host->data;
>         int c = cmd->opcode;
> -       u32 irq_mask = TMIO_MASK_CMD;
>
>         switch (mmc_resp_type(cmd)) {
>         case MMC_RSP_NONE: c |= RESP_NONE; break;
> @@ -349,7 +348,7 @@ static int tmio_mmc_start_command(struct tmio_mmc_host *host,
>                         c |= TRANSFER_READ;
>         }
>
> -       tmio_mmc_enable_mmc_irqs(host, irq_mask);
> +       tmio_mmc_enable_mmc_irqs(host, TMIO_MASK_CMD);
>
>         /* Fire off the command */
>         sd_ctrl_write32_as_16_and_16(host, CTL_ARG_REG, cmd->arg);
> --
> 2.7.4
>