[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <dfc3c810-8918-add4-b818-8b9c294f5ea4@infradead.org>
Date: Mon, 30 Jul 2018 10:54:05 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Tejun Heo <tj@...nel.org>, Pavel Machek <pavel@....cz>
Cc: Johannes Weiner <hannes@...xchg.org>,
Ingo Molnar <mingo@...hat.com>,
Peter Zijlstra <peterz@...radead.org>,
Andrew Morton <akpm@...ux-foundation.org>,
Linus Torvalds <torvalds@...ux-foundation.org>,
Suren Baghdasaryan <surenb@...gle.com>,
Vinayak Menon <vinmenon@...eaurora.org>,
Christopher Lameter <cl@...ux.com>,
Mike Galbraith <efault@....de>,
Shakeel Butt <shakeelb@...gle.com>, linux-mm@...ck.org,
cgroups@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel-team@...com
Subject: Re: [PATCH 0/10] psi: pressure stall information for CPU, memory, and
IO v2
On 07/30/2018 10:51 AM, Tejun Heo wrote:
> Hello,
>
> On Mon, Jul 30, 2018 at 07:39:40PM +0200, Pavel Machek wrote:
>>> I'd rather have the internal config symbol match the naming scheme in
>>> the code, where psi is a shorter, unique token as copmared to e.g.
>>> pressure, press, prsr, etc.
>>
>> I'd do "pressure", really. Yes, psi is shorter, but I'd say that
>> length is not really important there.
>
> This is an extreme bikeshedding without any relevance. You can make
> suggestions but please lay it to the rest. There isn't any general
> consensus against the current name and you're just trying to push your
> favorite name without proper justifications after contributing nothing
> to the project. Please stop.
>
> Thanks.
I'd say he's trying to make something that is readable and easier to
understand for users.
Thanks.
--
~Randy
Powered by blists - more mailing lists