lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <201807301417027670826@zte.com.cn>
Date:   Mon, 30 Jul 2018 14:17:02 +0800 (CST)
From:   <wang.yi59@....com.cn>
To:     <rostedt@...dmis.org>
Cc:     <tglx@...utronix.de>, <mingo@...hat.com>, <hpa@...or.com>,
        <x86@...nel.org>, <douly.fnst@...fujitsu.com>, <jgross@...e.com>,
        <ville.syrjala@...ux.intel.com>, <len.brown@...el.com>,
        <linux-kernel@...r.kernel.org>, <gregkh@...uxfoundation.org>,
        <jiang.biao2@....com.cn>, <zhong.weidong@....com.cn>,
        <trivial@...nel.org>
Subject: Re: [PATCH] x86/apic: fix two slight indenting

Thanks a lot, Steven.










---

Best wishes

Yi Wang






Original Mail



Sender: StevenRostedt <rostedt@...dmis.org>
To: Wang Yi10129963;
CC: tglx@...utronix.de <tglx@...utronix.de>mingo@...hat.com <mingo@...hat.com>hpa@...or.com <hpa@...or.com>x86@...nel.org <x86@...nel.org>douly.fnst@...fujitsu.com <douly.fnst@...fujitsu.com>jgross@...e.com <jgross@...e.com>ville.syrjala@...ux.intel.com <ville.syrjala@...ux.intel.com>len.brown@...el.com <len.brown@...el.com>linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>gregkh@...uxfoundation.org <gregkh@...uxfoundation.org>Jiang Biao10062664;Zhong Weidong10001088;trivial@...nel.org <trivial@...nel.org>
Date: 2018/07/27 23:33
Subject: Re: [PATCH] x86/apic: fix two slight indenting



This looks like it should go through the trivial tree. Although I'm not
the maintainer of this code, it looks reasonable to me, and I'll give
my:

Acked-by: Steven Rostedt (VMware) <rostedt@...dmis.org>

-- Steve


On Fri, 27 Jul 2018 14:15:03 +0800
Yi Wang <wang.yi59@....com.cn> wrote:

> There are two inconsistent indenting in calibrate_APIC_clock()
> and activate_managed(). Remove the surplus TAB.
> 
> Signed-off-by: Yi Wang <wang.yi59@....com.cn>
> Reviewed-by: Jiang Biao <jiang.biao2@....com.cn>
> ---
>  arch/x86/kernel/apic/apic.c   | 2 +-
>  arch/x86/kernel/apic/vector.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/x86/kernel/apic/apic.c b/arch/x86/kernel/apic/apic.c
> index 5071cc7..f222ebc 100644
> --- a/arch/x86/kernel/apic/apic.c
> +++ b/arch/x86/kernel/apic/apic.c
> @@ -937,7 +937,7 @@ static int __init calibrate_APIC_clock(void)
>  
>      if (levt->features & CLOCK_EVT_FEAT_DUMMY) {
>          pr_warning("APIC timer disabled due to verification failure\n");
> -            return -1;
> +        return -1;
>      }
>  
>      return 0;
> diff --git a/arch/x86/kernel/apic/vector.c b/arch/x86/kernel/apic/vector.c
> index b708f59..19e0b2f 100644
> --- a/arch/x86/kernel/apic/vector.c
> +++ b/arch/x86/kernel/apic/vector.c
> @@ -433,7 +433,7 @@ static int activate_managed(struct irq_data *irqd)
>          pr_err("Managed startup irq %u, no vector available\n",
>                 irqd->irq);
>      }
> -       return ret;
> +    return ret;
>  }
>  
>  static int x86_vector_activate(struct irq_domain *dom, struct irq_data *irqd,
<div class="zcontentRow"><p style="font-size:12px;font-family:arial;">Thanks a lot,&nbsp;<span style="line-height: 21px;">Steven.</span></p><p style="font-size:12px;font-family:arial;"><br></p><div class="zMailSign" unonamech="汪翼10129963" unonameen="wang yi10129963"><p class="zMailSignTitle" unonamech="汪翼10129963" unonameen="wang yi10129963" style="display: none;"><label class="sign_nameUno"></label><span class="sign_arrow"></span></p><div class="zMailSignContent"><div><p>---</p><p>Best wishes</p><p>Yi Wang</p></div></div></div><div><div class="zhistoryRow" style="display:block"><div class="zhistoryDes" style="width: 100%; height: 28px; line-height: 28px; background-color: #E0E5E9; color: #1388FF; text-align: center;" language-data="HistoryOrgTxt">Original Mail</div><div id="zwriteHistoryContainer"><div class="control-group zhistoryPanel"><div class="zhistoryHeader" style="padding: 8px; background-color: #F5F6F8;"><div><strong language-data="HistorySenderTxt">Sender:&nbsp;</strong><span class="zreadUserName">StevenRostedt &lt;rostedt@...dmis.org&gt;</span></div><div><strong language-data="HistoryTOTxt">To:&nbsp;</strong><span class="zreadUserName" style="display: inline;">Wang Yi10129963;</span></div><div><strong language-data="HistoryCCTxt">CC:&nbsp;</strong><span class="zreadUserName" style="display: inline;">tglx@...utronix.de &lt;tglx@...utronix.de&gt;</span><span class="zreadUserName" style="display: inline;">mingo@...hat.com &lt;mingo@...hat.com&gt;</span><span class="zreadUserName" style="display: inline;">hpa@...or.com &lt;hpa@...or.com&gt;</span><span class="zreadUserName" style="display: inline;">x86@...nel.org &lt;x86@...nel.org&gt;</span><span class="zreadUserName" style="display: inline;">douly.fnst@...fujitsu.com &lt;douly.fnst@...fujitsu.com&gt;</span><span class="zreadUserName" style="display: inline;">jgross@...e.com &lt;jgross@...e.com&gt;</span><span class="zreadUserName" style="display: inline;">ville.syrjala@...ux.intel.com &lt;ville.syrjala@...ux.intel.com&gt;</span><span class="zreadUserName" style="display: inline;">len.brown@...el.com &lt;len.brown@...el.com&gt;</span><span class="zreadUserName" style="display: inline;">linux-kernel@...r.kernel.org &lt;linux-kernel@...r.kernel.org&gt;</span><span class="zreadUserName" style="display: inline;">gregkh@...uxfoundation.org &lt;gregkh@...uxfoundation.org&gt;</span><span class="zreadUserName" style="display: inline;">Jiang Biao10062664;</span><span class="zreadUserName" style="display: inline;">Zhong Weidong10001088;</span><span class="zreadUserName" style="display: inline;">trivial@...nel.org &lt;trivial@...nel.org&gt;</span></div><div><strong language-data="HistoryDateTxt">Date:&nbsp;</strong><span class="">2018/07/27 23:33</span></div><div><strong language-data="HistorySubjectTxt">Subject:&nbsp;</strong><span class="zreadTitle"><strong>Re: [PATCH] x86/apic: fix two slight indenting</strong></span></div></div><div class="zhistoryContent"><div><br>This&nbsp;looks&nbsp;like&nbsp;it&nbsp;should&nbsp;go&nbsp;through&nbsp;the&nbsp;trivial&nbsp;tree.&nbsp;Although&nbsp;I'm&nbsp;not<br>the&nbsp;maintainer&nbsp;of&nbsp;this&nbsp;code,&nbsp;it&nbsp;looks&nbsp;reasonable&nbsp;to&nbsp;me,&nbsp;and&nbsp;I'll&nbsp;give<br>my:<br><br>Acked-by:&nbsp;Steven&nbsp;Rostedt&nbsp;(VMware)&nbsp;&lt;rostedt@...dmis.org&gt;<br><br>--&nbsp;Steve<br><br><br>On&nbsp;Fri,&nbsp;27&nbsp;Jul&nbsp;2018&nbsp;14:15:03&nbsp;+0800<br>Yi&nbsp;Wang&nbsp;&lt;wang.yi59@....com.cn&gt;&nbsp;wrote:<br><br>&gt;&nbsp;There&nbsp;are&nbsp;two&nbsp;inconsistent&nbsp;indenting&nbsp;in&nbsp;calibrate_APIC_clock()<br>&gt;&nbsp;and&nbsp;activate_managed().&nbsp;Remove&nbsp;the&nbsp;surplus&nbsp;TAB.<br>&gt;&nbsp;<br>&gt;&nbsp;Signed-off-by:&nbsp;Yi&nbsp;Wang&nbsp;&lt;wang.yi59@....com.cn&gt;<br>&gt;&nbsp;Reviewed-by:&nbsp;Jiang&nbsp;Biao&nbsp;&lt;jiang.biao2@....com.cn&gt;<br>&gt;&nbsp;---<br>&gt;&nbsp;&nbsp;arch/x86/kernel/apic/apic.c&nbsp;&nbsp;&nbsp;|&nbsp;2&nbsp;+-<br>&gt;&nbsp;&nbsp;arch/x86/kernel/apic/vector.c&nbsp;|&nbsp;2&nbsp;+-<br>&gt;&nbsp;&nbsp;2&nbsp;files&nbsp;changed,&nbsp;2&nbsp;insertions(+),&nbsp;2&nbsp;deletions(-)<br>&gt;&nbsp;<br>&gt;&nbsp;diff&nbsp;--git&nbsp;a/arch/x86/kernel/apic/apic.c&nbsp;b/arch/x86/kernel/apic/apic.c<br>&gt;&nbsp;index&nbsp;5071cc7..f222ebc&nbsp;100644<br>&gt;&nbsp;---&nbsp;a/arch/x86/kernel/apic/apic.c<br>&gt;&nbsp;+++&nbsp;b/arch/x86/kernel/apic/apic.c<br>&gt;&nbsp;@@&nbsp;-937,7&nbsp;+937,7&nbsp;@@&nbsp;static&nbsp;int&nbsp;__init&nbsp;calibrate_APIC_clock(void)<br>&gt;&nbsp;&nbsp;<br>&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;if&nbsp;(levt-&gt;features&nbsp;&amp;&nbsp;CLOCK_EVT_FEAT_DUMMY)&nbsp;{<br>&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;pr_warning("APIC&nbsp;timer&nbsp;disabled&nbsp;due&nbsp;to&nbsp;verification&nbsp;failure\n");<br>&gt;&nbsp;-&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;return&nbsp;-1;<br>&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;return&nbsp;-1;<br>&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;}<br>&gt;&nbsp;&nbsp;<br>&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;return&nbsp;0;<br>&gt;&nbsp;diff&nbsp;--git&nbsp;a/arch/x86/kernel/apic/vector.c&nbsp;b/arch/x86/kernel/apic/vector.c<br>&gt;&nbsp;index&nbsp;b708f59..19e0b2f&nbsp;100644<br>&gt;&nbsp;---&nbsp;a/arch/x86/kernel/apic/vector.c<br>&gt;&nbsp;+++&nbsp;b/arch/x86/kernel/apic/vector.c<br>&gt;&nbsp;@@&nbsp;-433,7&nbsp;+433,7&nbsp;@@&nbsp;static&nbsp;int&nbsp;activate_managed(struct&nbsp;irq_data&nbsp;*irqd)<br>&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;pr_err("Managed&nbsp;startup&nbsp;irq&nbsp;%u,&nbsp;no&nbsp;vector&nbsp;available\n",<br>&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;irqd-&gt;irq);<br>&gt;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;}<br>&gt;&nbsp;-&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;&nbsp;return&nbsp;ret;<br>&gt;&nbsp;+&nbsp;&nbsp;&nbsp;&nbsp;return&nbsp;ret;<br>&gt;&nbsp;&nbsp;}<br>&gt;&nbsp;&nbsp;<br>&gt;&nbsp;&nbsp;static&nbsp;int&nbsp;x86_vector_activate(struct&nbsp;irq_domain&nbsp;*dom,&nbsp;struct&nbsp;irq_data&nbsp;*irqd,<br></div></div></div></div></div></div><p><br></p></div>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ