linux-kernel - [tip:core/debugobjects] debugobjects: Make stack check warning more informative

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 30 Jul 2018 12:39:52 -0700
From:   "tip-bot for Joel Fernandes (Google)" <tipbot@...or.com>
To:     linux-tip-commits@...r.kernel.org
Cc:     arnd@...db.de, yang.shi@...ux.alibaba.com, hpa@...or.com,
        longman@...hat.com, tglx@...utronix.de, joel@...lfernandes.org,
        mingo@...nel.org, linux-kernel@...r.kernel.org
Subject: [tip:core/debugobjects] debugobjects: Make stack check warning more
 informative

Commit-ID:  fc91a3c4c27acdca0bc13af6fbb68c35cfd519f2
Gitweb:     https://git.kernel.org/tip/fc91a3c4c27acdca0bc13af6fbb68c35cfd519f2
Author:     Joel Fernandes (Google) <joel@...lfernandes.org>
AuthorDate: Mon, 23 Jul 2018 14:25:31 -0700
Committer:  Thomas Gleixner <tglx@...utronix.de>
CommitDate: Mon, 30 Jul 2018 21:36:37 +0200

debugobjects: Make stack check warning more informative

While debugging an issue debugobject tracking warned about an annotation
issue of an object on stack. It turned out that the issue was due to the
object in concern being on a different stack which was due to another
issue.

Thomas suggested to print the pointers and the location of the stack for
the currently running task. This helped to figure out that the object was
on the wrong stack.

As this is general useful information for debugging similar issues, make
the error message more informative by printing the pointers.

[ tglx: Massaged changelog ]

Signed-off-by: Joel Fernandes (Google) <joel@...lfernandes.org>
Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
Acked-by: Waiman Long <longman@...hat.com>
Acked-by: Yang Shi <yang.shi@...ux.alibaba.com>
Cc: kernel-team@...roid.com
Cc: Arnd Bergmann <arnd@...db.de>
Cc: astrachan@...gle.com
Link: https://lkml.kernel.org/r/20180723212531.202328-1-joel@joelfernandes.org

---
 lib/debugobjects.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/lib/debugobjects.c b/lib/debugobjects.c
index 994be4805cec..24c1df0d7466 100644
--- a/lib/debugobjects.c
+++ b/lib/debugobjects.c
@@ -360,9 +360,12 @@ static void debug_object_is_on_stack(void *addr, int onstack)
 
 	limit++;
 	if (is_on_stack)
-		pr_warn("object is on stack, but not annotated\n");
+		pr_warn("object %p is on stack %p, but NOT annotated.\n", addr,
+			 task_stack_page(current));
 	else
-		pr_warn("object is not on stack, but annotated\n");
+		pr_warn("object %p is NOT on stack %p, but annotated.\n", addr,
+			 task_stack_page(current));
+
 	WARN_ON(1);
 }