[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <87muu8l6ho.fsf@notabene.neil.brown.name>
Date: Tue, 31 Jul 2018 08:10:43 +1000
From: NeilBrown <neil@...wn.name>
To: Nishad Kamdar <nishadkamdar@...il.com>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Christian Lütke-Stetzkamp <christian@...mp.de>,
John Crispin <blogic@...nwrt.org>, devel@...verdev.osuosl.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: mt7621-mmc: Use BIT macro instead of explicit shifting in board.h
On Fri, Jul 27 2018, Nishad Kamdar wrote:
> Replace explicit shifting with BIT macro in board.h.
> Issue found by checkpatch.
>
> Signed-off-by: Nishad Kamdar <nishadkamdar@...il.com>
Reviewed-by: NeilBrown <neil@...wn.name>
Thanks,
NeilBrown
> ---
> drivers/staging/mt7621-mmc/board.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/mt7621-mmc/board.h b/drivers/staging/mt7621-mmc/board.h
> index a7d82f321b00..983791ee308d 100644
> --- a/drivers/staging/mt7621-mmc/board.h
> +++ b/drivers/staging/mt7621-mmc/board.h
> @@ -36,10 +36,10 @@
> #ifndef __ARCH_ARM_MACH_BOARD_H
> #define __ARCH_ARM_MACH_BOARD_H
>
> -#define MSDC_CD_PIN_EN (1 << 0) /* card detection pin is wired */
> -#define MSDC_WP_PIN_EN (1 << 1) /* write protection pin is wired */
> -#define MSDC_RST_PIN_EN (1 << 2) /* emmc reset pin is wired */
> -#define MSDC_REMOVABLE (1 << 5) /* removable slot */
> +#define MSDC_CD_PIN_EN BIT(0) /* card detection pin is wired */
> +#define MSDC_WP_PIN_EN BIT(1) /* write protection pin is wired */
> +#define MSDC_RST_PIN_EN BIT(2) /* emmc reset pin is wired */
> +#define MSDC_REMOVABLE BIT(5) /* removable slot */
>
> #define MSDC_SMPL_RISING (0)
> #define MSDC_SMPL_FALLING (1)
> --
> 2.17.1
Download attachment "signature.asc" of type "application/pgp-signature" (833 bytes)
Powered by blists - more mailing lists