linux-kernel - Re: [PATCH V5 2/2] scsi: ufs: Add configfs support for ufs provisioning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <cd621e88-99c6-b2a0-8ab9-84761fb0a1f9@codeaurora.org>
Date:   Tue, 31 Jul 2018 10:48:25 +0530
From:   Sayali Lokhande <sayalil@...eaurora.org>
To:     Evan Green <evgreen@...omium.org>
Cc:     Bart.VanAssche@....com, Vinayak Holikatti <vinholikatti@...il.com>,
        linux-kernel@...r.kernel.org, asutoshd@...eaurora.org,
        riteshh@...eaurora.org, cang@...eaurora.org,
        martin.petersen@...cle.com, subhashj@...eaurora.org,
        linux-scsi@...r.kernel.org, vivek.gautam@...eaurora.org,
        Rajendra Nayak <rnayak@...eaurora.org>,
        jejb@...ux.vnet.ibm.com, gregkh@...uxfoundation.org
Subject: Re: [PATCH V5 2/2] scsi: ufs: Add configfs support for ufs
 provisioning



On 7/31/2018 5:09 AM, Evan Green wrote:
> On Mon, Jul 30, 2018 at 12:46 AM Sayali Lokhande <sayalil@...eaurora.org> wrote:
>> Hi Evan,
>>
>>
>> On 7/18/2018 1:53 AM, Evan Green wrote:
> ...
>>> I'm not dead set on binary, since as above I could do it either way,
>>> but it seemed worth at least talking through. Let me know what you
>>> think.
>>> -Evan
>> I am using ASCII format for reading/writing to config desc as it will be
>> more readable for users and easier/comfortable to compare any value to
>> default spec value(if required).
>> So I don't really see any harm in using current ASCII format for
>> provisioning purpose.
> I'm not convinced by those arguments, but ultimately it's between you
> and the maintainers. If you're going with the ASCII route, then I have
> another review comment. Currently in your patch, if kstrtoint fails,
> you print, but then break out of the loop and try to write the
> partially parsed descriptor anyway. That "break" should probably be
> changed to a "goto out".
>
> -Evan
Agreed. I will replace that break with "goto out" .