| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <201807311816.Yws9ab6F%fengguang.wu@intel.com>
Date: Tue, 31 Jul 2018 18:33:32 +0800
From: kbuild test robot <lkp@...el.com>
To: Lyude Paul <lyude@...hat.com>
Cc: kbuild-all@...org, nouveau@...ts.freedesktop.org,
Ben Skeggs <bskeggs@...hat.com>,
David Airlie <airlied@...ux.ie>,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] drm/nouveau: Prevent redundant connector probes from
ACPI
Hi Lyude,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on v4.18-rc7 next-20180727]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Lyude-Paul/drm-nouveau-Print-debug-message-on-ACPI-probe-event/20180731-150343
config: arm-multi_v7_defconfig (attached as .config)
compiler: arm-linux-gnueabi-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=arm
All errors (new ones prefixed by >>):
In file included from include/linux/kernel.h:10:0,
from include/linux/list.h:9,
from include/linux/agp_backend.h:33,
from include/drm/drmP.h:35,
from drivers/gpu/drm/nouveau/nouveau_display.c:28:
drivers/gpu/drm/nouveau/nouveau_display.c: In function 'nouveau_display_init':
>> drivers/gpu/drm/nouveau/nouveau_display.c:431:16: error: 'struct nouveau_drm' has no member named 'acpi_hpd_enabled'
WRITE_ONCE(drm->acpi_hpd_enabled, false);
^
include/linux/compiler.h:275:17: note: in definition of macro 'WRITE_ONCE'
union { typeof(x) __val; char __c[1]; } __u = \
^
>> drivers/gpu/drm/nouveau/nouveau_display.c:431:16: error: 'struct nouveau_drm' has no member named 'acpi_hpd_enabled'
WRITE_ONCE(drm->acpi_hpd_enabled, false);
^
include/linux/compiler.h:276:30: note: in definition of macro 'WRITE_ONCE'
{ .__val = (__force typeof(x)) (val) }; \
^
>> drivers/gpu/drm/nouveau/nouveau_display.c:431:16: error: 'struct nouveau_drm' has no member named 'acpi_hpd_enabled'
WRITE_ONCE(drm->acpi_hpd_enabled, false);
^
include/linux/compiler.h:277:22: note: in definition of macro 'WRITE_ONCE'
__write_once_size(&(x), __u.__c, sizeof(x)); \
^
>> drivers/gpu/drm/nouveau/nouveau_display.c:431:16: error: 'struct nouveau_drm' has no member named 'acpi_hpd_enabled'
WRITE_ONCE(drm->acpi_hpd_enabled, false);
^
include/linux/compiler.h:277:42: note: in definition of macro 'WRITE_ONCE'
__write_once_size(&(x), __u.__c, sizeof(x)); \
^
drivers/gpu/drm/nouveau/nouveau_display.c: In function 'nouveau_display_fini':
drivers/gpu/drm/nouveau/nouveau_display.c:458:17: error: 'struct nouveau_drm' has no member named 'acpi_hpd_enabled'
WRITE_ONCE(drm->acpi_hpd_enabled, true);
^
include/linux/compiler.h:275:17: note: in definition of macro 'WRITE_ONCE'
union { typeof(x) __val; char __c[1]; } __u = \
^
drivers/gpu/drm/nouveau/nouveau_display.c:458:17: error: 'struct nouveau_drm' has no member named 'acpi_hpd_enabled'
WRITE_ONCE(drm->acpi_hpd_enabled, true);
^
include/linux/compiler.h:276:30: note: in definition of macro 'WRITE_ONCE'
{ .__val = (__force typeof(x)) (val) }; \
^
drivers/gpu/drm/nouveau/nouveau_display.c:458:17: error: 'struct nouveau_drm' has no member named 'acpi_hpd_enabled'
WRITE_ONCE(drm->acpi_hpd_enabled, true);
^
include/linux/compiler.h:277:22: note: in definition of macro 'WRITE_ONCE'
__write_once_size(&(x), __u.__c, sizeof(x)); \
^
drivers/gpu/drm/nouveau/nouveau_display.c:458:17: error: 'struct nouveau_drm' has no member named 'acpi_hpd_enabled'
WRITE_ONCE(drm->acpi_hpd_enabled, true);
^
include/linux/compiler.h:277:42: note: in definition of macro 'WRITE_ONCE'
__write_once_size(&(x), __u.__c, sizeof(x)); \
^
vim +431 drivers/gpu/drm/nouveau/nouveau_display.c
404
405 int
406 nouveau_display_init(struct drm_device *dev, bool runtime)
407 {
408 struct nouveau_display *disp = nouveau_display(dev);
409 struct nouveau_drm *drm = nouveau_drm(dev);
410 struct drm_connector *connector;
411 struct drm_connector_list_iter conn_iter;
412 int ret;
413
414 ret = disp->init(dev);
415 if (ret)
416 return ret;
417
418 /* enable hotplug interrupts */
419 drm_connector_list_iter_begin(dev, &conn_iter);
420 nouveau_for_each_non_mst_connector_iter(connector, &conn_iter) {
421 struct nouveau_connector *conn = nouveau_connector(connector);
422 nvif_notify_get(&conn->hpd);
423 }
424 drm_connector_list_iter_end(&conn_iter);
425
426 /* disable ACPI hotplug handling to prevent duplicate connector
427 * probes
428 * FIXME: make sure that WRITE_ONCE() implies a store barrier
429 * beforehand
430 */
> 431 WRITE_ONCE(drm->acpi_hpd_enabled, false);
432
433 /* enable flip completion events */
434 nvif_notify_get(&drm->flip);
435 return ret;
436 }
437
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
Download attachment ".config.gz" of type "application/gzip" (43915 bytes)
Powered by blists - more mailing lists