linux-kernel - Re: [PATCH v2 16/17] driver/edac: enable Hygon support to AMD64 EDAC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <62003623-b4ee-9ddd-261a-d48b7cf2ce36@hygon.cn>
Date:   Tue, 31 Jul 2018 18:46:54 +0800
From:   Pu Wen <puwen@...on.cn>
To:     Paolo Bonzini <pbonzini@...hat.com>, tglx@...utronix.de,
        bp@...en8.de, thomas.lendacky@....com, mingo@...hat.com,
        hpa@...or.com, peterz@...radead.org, tony.luck@...el.com,
        rkrcmar@...hat.com, boris.ostrovsky@...cle.com, jgross@...e.com,
        rjw@...ysocki.net, lenb@...nel.org, viresh.kumar@...aro.org,
        mchehab@...nel.org, trenn@...e.com, shuah@...nel.org,
        x86@...nel.org
Cc:     linux-kernel@...r.kernel.org, linux-arch@...r.kernel.org,
        kvm@...r.kernel.org
Subject: Re: [PATCH v2 16/17] driver/edac: enable Hygon support to AMD64 EDAC
 driver

On 2018/7/31 15:38, Paolo Bonzini wrote:
> But if that's the case, it doesn't make sense to have a new vendor!  If
> AMD's 17h and Hygon's 18h ever diverge, you could always choose the
> right behavior based on the family, without checking the vendor.
> 
> However, if the x86 maintainers prefer to have a new X86_VENDOR_*
> constant, I'd just ignore the fact that AMD will skip family 18h, and
> introduce vendor checks along the lines below.  This has the advantage
> that it's not an issue if AMD ends up _not_ skipping family 18h.

Thanks for the suggestion. It's reasonable for the fully consideration.
For code consistency, will check explicitly for Hygon before testing
family 18h in next patch set.

Thanks,
Pu Wen