linux-kernel - Re: [PATCH] media: omap2: omapfb: fix bugon.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <1852918.sFt5Xj4oDG@amdc3058>
Date:   Tue, 31 Jul 2018 13:04:14 +0200
From:   Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:     kbuild test robot <fengguang.wu@...el.com>
Cc:     Mauro Carvalho Chehab <m.chehab@...sung.com>, kbuild-all@...org,
        linux-kernel@...r.kernel.org, linux-media@...r.kernel.org,
        Tomi Valkeinen <tomi.valkeinen@...com>,
        linux-omap@...r.kernel.org, linux-fbdev@...r.kernel.org,
        dri-devel@...ts.freedesktop.org
Subject: Re: [PATCH] media: omap2: omapfb: fix bugon.cocci warnings

On Thursday, July 26, 2018 01:57:00 AM kbuild test robot wrote:
> From: kbuild test robot <fengguang.wu@...el.com>
> 
> drivers/video/fbdev/omap2/omapfb/dss/dss_features.c:895:2-5: WARNING: Use BUG_ON instead of if condition followed by BUG.
> Please make sure the condition has no side effects (see conditional BUG_ON definition in include/asm-generic/bug.h)
> 
>  Use BUG_ON instead of a if condition followed by BUG.
> 
> Semantic patch information:
>  This makes an effort to find cases where BUG() follows an if
>  condition on an expression and replaces the if condition and BUG()
>  with a BUG_ON having the conditional expression of the if statement
>  as argument.
> 
> Generated by: scripts/coccinelle/misc/bugon.cocci
> 
> Fixes: 7378f1149884 ("media: omap2: omapfb: allow building it with COMPILE_TEST")
> Signed-off-by: kbuild test robot <fengguang.wu@...el.com>

Patch queued for 4.19 (w/ "media"->"fbdev" fixup in the patch title), thanks.

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics