linux-kernel - Re: [PATCH] mips:sgi-ip22:Check return value from kzalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180731012718.bnct37fdtiaezdyd@pburton-laptop>
Date:   Mon, 30 Jul 2018 18:27:18 -0700
From:   Paul Burton <paul.burton@...s.com>
To:     RAGHU Halharvi <raghuhack78@...il.com>
Cc:     linux-mips@...ux-mips.org, linux-kernel@...r.kernel.org,
        jhogan@...nel.org, ralf@...ux-mips.org
Subject: Re: [PATCH] mips:sgi-ip22:Check return value from kzalloc

Hi Raghu,

On Tue, Jul 17, 2018 at 05:11:45PM +0530, RAGHU Halharvi wrote:
> Signed-off-by: RAGHU Halharvi <raghuhack78@...il.com>
> ---
>  arch/mips/sgi-ip22/ip22-gio.c | 2 ++
>  1 file changed, 2 insertions(+)

You should write a commit message, even for trivial patches, which
describes the motivation for the patch. For more complex patches it
should also explain how the changes being made solve a problem, or
clarify anything non-obvious about the way the patched code works.

In general, read Documentation/process/submitting-patches.rst

> diff --git a/arch/mips/sgi-ip22/ip22-gio.c b/arch/mips/sgi-ip22/ip22-gio.c
> index b225033aade6..5aaf40a1743b 100644
> --- a/arch/mips/sgi-ip22/ip22-gio.c
> +++ b/arch/mips/sgi-ip22/ip22-gio.c
> @@ -363,6 +363,8 @@ static void ip22_check_gio(int slotno, unsigned long addr, int irq)
>  		printk(KERN_INFO "GIO: slot %d : %s (id %x)\n",
>  		       slotno, name, id);
>  		gio_dev = kzalloc(sizeof *gio_dev, GFP_KERNEL);
> +		if (!gio_dev)
> +			return -ENOMEM;

One especially important point for patches like this one is to make sure
that your code at least compiles. In this case you try to return an
error code from a function that returns void, which won't work.

Thanks,
    Paul