linux-kernel - Re: [PATCH] x86: kvm: Restrict X86_FEATURE_VMMCALL to x86

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Jul 2018 14:59:06 +0200
From:   Paolo Bonzini <pbonzini@...hat.com>
To:     whiteheadm@....org
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: kvm: Restrict X86_FEATURE_VMMCALL to x86_64 platform

On 31/07/2018 14:57, tedheadster wrote:
>>
>> This shouldn't be necessary; for systems that don't have virtualization
>> extensions, the comment explains why setting X86_FEATURE_VMMCALL is safe.
>>
>> But it is also wrong, because you can run a 32-bit kernel as a guest on
>> a 64-bit processor, and then it should set X86_FEATURE_VMMCALL because
>> the processor has the vmmcall instruction and not Intel's vmcall.
>>
> 
> Paolo,
>   I'm running this on a bare metal machine (no virtualization) with a
> 32-bit AMD i486 class cpu. Should the feature be showing up in
> /proc/cpuinfo under the 'flags' line? It does on my machine, and it
> looked wrong to me.

It's a bit silly, but it's not particularly wrong.

Paolo