linux-kernel - Re: [PATCH v2] tracefs: Annotate tracefs_ops with __ro_after

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5j+Zk564SijO=eXxryUTNojO7h-rgf_BuQMKesWb+zPOJg@mail.gmail.com>
Date:   Mon, 30 Jul 2018 17:25:06 -0700
From:   Kees Cook <keescook@...omium.org>
To:     Zubin Mithra <zsm@...omium.org>
Cc:     Steven Rostedt <rostedt@...dmis.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Guenter Roeck <groeck@...omium.org>
Subject: Re: [PATCH v2] tracefs: Annotate tracefs_ops with __ro_after_init

On Wed, Jul 25, 2018 at 11:00 AM, Kees Cook <keescook@...omium.org> wrote:
> On Wed, Jul 25, 2018 at 10:19 AM, Zubin Mithra <zsm@...omium.org> wrote:
>> tracefs_ops is initialized inside tracefs_create_instance_dir and not
>> modified after. tracefs_create_instance_dir allows for initialization
>> only once, and is called from create_trace_instances(marked __init),
>> which is called from tracer_init_tracefs(marked __init). Also, mark
>> tracefs_create_instance_dir as __init.
>>
>> Signed-off-by: Zubin Mithra <zsm@...omium.org>
>
> Reviewed-by: Kees Cook <keescook@...omium.org>

Steve, do you have a tree for this or should we rope akpm in? :)

-Kees

-- 
Kees Cook
Pixel Security