[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20180731170557.GK5719@sirena.org.uk>
Date: Tue, 31 Jul 2018 18:05:57 +0100
From: Mark Brown <broonie@...nel.org>
To: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Cc: lee.jones@...aro.org, robh+dt@...nel.org, mark.rutland@....com,
lgirdwood@...il.com, tiwai@...e.com, bgoswami@...eaurora.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
vkoul@...nel.org, alsa-devel@...a-project.org
Subject: Re: [PATCH v2 05/10] ASoC: wcd9335: add CLASS-H Controller support
On Fri, Jul 27, 2018 at 01:18:01PM +0100, Srinivas Kandagatla wrote:
> + res_val = WCD9XXX_CLASSH_CTRL_VCL_VREF_FILT_R_0KOHM;
> + switch (mode) {
> + case CLS_H_NORMAL:
> + res_val = WCD9XXX_CLASSH_CTRL_VCL_VREF_FILT_R_50KOHM;
> + val = WCD9XXX_A_ANA_HPH_PWR_LEVEL_NORMAL;
> + gain = DAC_GAIN_0DB;
> + ipeak = WCD9XXX_CLASSH_CTRL_CCL_1_DELTA_IPEAK_50MA;
> + break;
> + case CLS_AB:
> + val = WCD9XXX_A_ANA_HPH_PWR_LEVEL_NORMAL;
> + gain = DAC_GAIN_0DB;
> + ipeak = WCD9XXX_CLASSH_CTRL_CCL_1_DELTA_IPEAK_50MA;
> + break;
> + case CLS_H_HIFI:
> + val = WCD9XXX_A_ANA_HPH_PWR_LEVEL_UHQA;
> + gain = DAC_GAIN_M0P2DB;
> + ipeak = WCD9XXX_CLASSH_CTRL_CCL_1_DELTA_IPEAK_50MA;
> + break;
> + case CLS_H_LP:
> + val = WCD9XXX_A_ANA_HPH_PWR_LEVEL_LP;
> + ipeak = WCD9XXX_CLASSH_CTRL_CCL_1_DELTA_IPEAK_30MA;
> + break;
> + };
This is missing a default case for error checking, and you don't need
the semicolon at the end either.
Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)
Powered by blists - more mailing lists