linux-kernel - Re: [PATCH] nohz: Fix local_timer_softirq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180731171426.GD28353@lerouge>
Date:   Tue, 31 Jul 2018 19:14:27 +0200
From:   Frederic Weisbecker <frederic@...nel.org>
To:     Anna-Maria Gleixner <anna-maria@...utronix.de>
Cc:     linux-kernel@...r.kernel.org, bigeasy@...utronix.de,
        tglx@...utronix.de, bristot@...hat.com, paulmck@...ux.vnet.ibm.com,
        peterz@...radead.org
Subject: Re: [PATCH] nohz: Fix local_timer_softirq_pending()

On Tue, Jul 31, 2018 at 06:13:58PM +0200, Anna-Maria Gleixner wrote:
> local_timer_softirq_pending() checks whether the timer softirq is
> pending with: local_softirq_pending() & TIMER_SOFTIRQ.
> 
> This is wrong because TIMER_SOFTIRQ is the softirq number and not a
> bitmask. So the test checks for the wrong bit.
> 
> Use BIT(TIMER_SOFTIRQ) instead.
> 
> Fixes: 5d62c183f9e9 ("nohz: Prevent a timer interrupt storm in tick_nohz_stop_sched_tick()")
> Signed-off-by: Anna-Maria Gleixner <anna-maria@...utronix.de>

Acked-by: Frederic Weisbecker <frederic@...nel.org>

Thanks!