linux-kernel - Re: [PATCH] block/compat_ioctl: fix range check in BLKGETSIZE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACGdZY+cHaKSMKqpM3p5SJq9sVyZHViDUoCTmTusr=Dw1iiR0A@mail.gmail.com>
Date:   Tue, 31 Jul 2018 11:23:34 -0700
From:   Khazhismel Kumykov <khazhy@...gle.com>
To:     axboe@...nel.dk
Cc:     linux-block@...r.kernel.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        Khazhismel Kumykov <khazhy@...gle.com>
Subject: Re: [PATCH] block/compat_ioctl: fix range check in BLKGETSIZE

Ping?

On Fri, Apr 6, 2018 at 3:23 PM, Khazhismel Kumykov <khazhy@...gle.com> wrote:
> kernel ulong and compat_ulong_t may not be same width. Use type directly
> to eliminate mismatches.
>
> This would result in truncation rather than EFBIG for 32bit mode for
> large disks.
>
> Signed-off-by: Khazhismel Kumykov <khazhy@...gle.com>
> ---
>  block/compat_ioctl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/compat_ioctl.c b/block/compat_ioctl.c
> index 6ca015f92766..3a2c77f07da8 100644
> --- a/block/compat_ioctl.c
> +++ b/block/compat_ioctl.c
> @@ -388,7 +388,7 @@ long compat_blkdev_ioctl(struct file *file, unsigned cmd, unsigned long arg)
>                 return 0;
>         case BLKGETSIZE:
>                 size = i_size_read(bdev->bd_inode);
> -               if ((size >> 9) > ~0UL)
> +               if ((size >> 9) > ~((compat_ulong_t)0UL))
>                         return -EFBIG;
>                 return compat_put_ulong(arg, size >> 9);
>
> --
> 2.17.0.484.g0c8726318c-goog
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4843 bytes)