linux-kernel - Re: [PATCH 0/2] fs/quota: Fix potential spectre v1 gadgets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 31 Jul 2018 13:43:44 -0500
From:   Josh Poimboeuf <jpoimboe@...hat.com>
To:     Jeremy Cline <jcline@...hat.com>
Cc:     Jan Kara <jack@...e.com>, linux-kernel@...r.kernel.org,
        Andreas Dilger <adilger@...ger.ca>
Subject: Re: [PATCH 0/2] fs/quota: Fix potential spectre v1 gadgets

On Tue, Jul 31, 2018 at 01:37:29AM +0000, Jeremy Cline wrote:
> Hi folks,
> 
> This series unifies XQM_MAXQUOTAS with MAXQUOTAS, which were both being
> used to perform bounds checks on arrays, and then sanitizes 'type' so it
> can't be used in speculative out-of-bounds array access.
> 
> Jeremy Cline (2):
>   fs/quota: Replace XQM_MAXQUOTAS usage with MAXQUOTAS
>   fs/quota: Fix spectre gadget in do_quotactl
> 
>  fs/quota/quota.c               | 14 +++++++-------
>  include/linux/quota.h          |  8 +-------
>  include/uapi/linux/dqblk_xfs.h |  5 -----
>  3 files changed, 8 insertions(+), 19 deletions(-)

Looks good to me, though this might hinge on the discussion with
Andreas:

  https://lkml.kernel.org/r/E3E7B6AF-3819-4998-9B12-DACB4EBC14F1@dilger.ca

-- 
Josh