linux-kernel - Re: [PATCH v2 3/9] scsi: build scsi_common.o for all scsi passthrough request users

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a5b545eade66f95c9a9ecf37676306a8d395187c.camel@wdc.com>
Date:   Tue, 31 Jul 2018 20:01:16 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "keescook@...omium.org" <keescook@...omium.org>,
        "axboe@...nel.dk" <axboe@...nel.dk>
CC:     "vinod.koul@...el.com" <vinod.koul@...el.com>,
        "david.kershner@...sys.com" <david.kershner@...sys.com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "hch@...radead.org" <hch@...radead.org>,
        "rdunlap@...radead.org" <rdunlap@...radead.org>,
        "u.kleine-koenig@...gutronix.de" <u.kleine-koenig@...gutronix.de>,
        "nab@...ux-iscsi.org" <nab@...ux-iscsi.org>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "hch@....de" <hch@....de>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "manoj@...ux.vnet.ibm.com" <manoj@...ux.vnet.ibm.com>,
        "sdharia@...eaurora.org" <sdharia@...eaurora.org>,
        "jgross@...e.com" <jgross@...e.com>,
        "cyrille.pitchen@...e-electrons.com" 
        <cyrille.pitchen@...e-electrons.com>,
        "linux-ide@...r.kernel.org" <linux-ide@...r.kernel.org>,
        "viresh.kumar@...aro.org" <viresh.kumar@...aro.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "target-devel@...r.kernel.org" <target-devel@...r.kernel.org>,
        "pombredanne@...b.com" <pombredanne@...b.com>,
        "bp@...en8.de" <bp@...en8.de>,
        "mrochs@...ux.vnet.ibm.com" <mrochs@...ux.vnet.ibm.com>,
        "tj@...nel.org" <tj@...nel.org>,
        "jejb@...ux.vnet.ibm.com" <jejb@...ux.vnet.ibm.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "sboyd@...eaurora.org" <sboyd@...eaurora.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "ukrishn@...ux.vnet.ibm.com" <ukrishn@...ux.vnet.ibm.com>
Subject: Re: [PATCH v2 3/9] scsi: build scsi_common.o for all scsi passthrough
 request users

On Tue, 2018-07-31 at 12:51 -0700, Kees Cook wrote:
> diff --git a/drivers/Makefile b/drivers/Makefile
> index 24cd47014657..a6abd7a856c6 100644
> --- a/drivers/Makefile
> +++ b/drivers/Makefile
> @@ -76,7 +76,7 @@ obj-$(CONFIG_DMA_SHARED_BUFFER) += dma-buf/
>  obj-$(CONFIG_NUBUS)		+= nubus/
>  obj-y				+= macintosh/
>  obj-$(CONFIG_IDE)		+= ide/
> -obj-$(CONFIG_SCSI)		+= scsi/
> +obj-y				+= scsi/
>  obj-y				+= nvme/
>  obj-$(CONFIG_ATA)		+= ata/
>  obj-$(CONFIG_TARGET_CORE)	+= target/

The above change not only selects scsi_common.o but also the following object
files: scsi.o hosts.o scsi_ioctl.o scsicam.o scsi_error.o scsi_lib.o scsi_scan.o
scsi_sysfs.o scsi_devinfo.o scsi_trace.o scsi_logging.o. That is a change that
has not been mentioned in the patch description. That makes me wonder whether
this is an intended change? Wouldn't a cleaner solution have been to move
scsi_common.c into a new directory?

Bart.