linux-kernel - Re: [PATCH v2 6/9] ide-cd: Remove redundant sense buffer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180731.143015.1326547191404152411.davem@davemloft.net>
Date:   Tue, 31 Jul 2018 14:30:15 -0700 (PDT)
From:   David Miller <davem@...emloft.net>
To:     keescook@...omium.org
Cc:     axboe@...nel.dk, hch@...radead.org, martin.petersen@...cle.com,
        jejb@...ux.vnet.ibm.com, tj@...nel.org, bp@...en8.de,
        manoj@...ux.vnet.ibm.com, mrochs@...ux.vnet.ibm.com,
        ukrishn@...ux.vnet.ibm.com, nab@...ux-iscsi.org,
        tglx@...utronix.de, pombredanne@...b.com, sboyd@...eaurora.org,
        cyrille.pitchen@...e-electrons.com, jgross@...e.com,
        viresh.kumar@...aro.org, u.kleine-koenig@...gutronix.de,
        sdharia@...eaurora.org, rdunlap@...radead.org,
        vinod.koul@...el.com, david.kershner@...sys.com,
        linux-block@...r.kernel.org, linux-ide@...r.kernel.org,
        linux-scsi@...r.kernel.org, target-devel@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 6/9] ide-cd: Remove redundant sense buffer

From: Kees Cook <keescook@...omium.org>
Date: Tue, 31 Jul 2018 12:51:51 -0700

> This is already able to process the sense buffer, so remove the redundant
> parsing during the failure path. This also fixes any possible stale values
> since the prior code did not check the sense length.
> 
> Signed-off-by: Kees Cook <keescook@...omium.org>

Acked-by: David S. Miller <davem@...emloft.net>