linux-kernel - Re: [PATCH] posix-timers: Remove the stack variable clockid_t introduced as part of Protect posix clock array access against speculation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1808012140160.1835@nanos.tec.linutronix.de>
Date:   Wed, 1 Aug 2018 21:50:29 +0200 (CEST)
From:   Thomas Gleixner <tglx@...utronix.de>
To:     Aashish Lakhwara <aashish.l@...sung.com>
cc:     linux-kernel@...r.kernel.org, himanshu.sh@...ssung.com,
        a.sahrawat@...sung.com, pankaj.m@...sung.com,
        Himanshu Shukla <himanshu.sh@...sung.com>
Subject: Re: [PATCH] posix-timers: Remove the stack variable clockid_t
 introduced as part of Protect posix clock array access against speculation

On Wed, 1 Aug 2018, Aashish Lakhwara wrote:

> Subject: [PATCH] posix-timers: Remove the stack variable clockid_t introduced as part of
    Protect posix clock array access against speculation

Documentation/process/submitting-patches.rst:

  For these reasons, the ``summary`` must be no more than 70-75
  characters, and it must describe both what the patch changes, as well
  as why the patch might be necessary.  It is challenging to be both
  succinct and descriptive, but that is what a well-written summary
  should do.

The above $subject violates all of these rules.

> The "array_index_mask_nospec" code has been updated to allow index
> argument to have const-qualified type.

> Now the stack variable "idx" is no longer required and can be removed.
> We should directly pass the const variable "id" to array_index_mask_nospec

We should? Changelogs are about facts. So having:

  The "array_index_mask_nospec" code has been updated to allow index
  argument to have const-qualified type.

  So the stack variable "idx" which was introduced in commit 19b558db12f9
  ("posix-timers: Protect posix clock array access against speculation") to
  cast the const argument 'id' is not longer required.

is factual and precise. Hmm?

> Signed-off-by: Aashish Lakhwara <aashish.l@...sung.com>
> Signed-off-by: Himanshu Shukla <himanshu.sh@...sung.com>

This SOB chain is wrong. Please read and follow the Docuentation.

Thanks,

	tglx