linux-kernel - Re: [PATCH 1/1] x86, pmem, acpi: Remove excessive ACPI Large Reference Count warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180801203827.ozkvldizkpsatmg5@hpe.com>
Date:   Wed, 1 Aug 2018 15:38:27 -0500
From:   Russ Anderson <rja@....com>
To:     "Moore, Robert" <robert.moore@...el.com>
Cc:     Mike Travis <mike.travis@....com>,
        "Schmauss, Erik" <erik.schmauss@...el.com>,
        "Wysocki, Rafael J" <rafael.j.wysocki@...el.com>,
        Len Brown <lenb@...nel.org>,
        Russ Anderson <russ.anderson@....com>,
        Dimitri Sivanich <dimitri.sivanich@....com>,
        Ross Zwisler <ross.zwisler@...ux.intel.com>,
        "Williams, Dan J" <dan.j.williams@...el.com>,
        "Verma, Vishal L" <vishal.l.verma@...el.com>,
        "Jiang, Dave" <dave.jiang@...el.com>,
        "linux-acpi@...r.kernel.org" <linux-acpi@...r.kernel.org>,
        "devel@...ica.org" <devel@...ica.org>,
        "linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 1/1] x86, pmem, acpi: Remove excessive ACPI Large
 Reference Count warnings

On Wed, Aug 01, 2018 at 07:49:14PM +0000, Moore, Robert wrote:
> Are there any actual memory leaks, or this a consequence of the number of sockets?

It is a consequence of the number of sockets.
It is not an actual memory leak.

Thanks.

> > -----Original Message-----
> > From: Mike Travis [mailto:mike.travis@....com]
> > Sent: Monday, July 30, 2018 12:56 PM
> > To: Moore, Robert <robert.moore@...el.com>; Schmauss, Erik
> > <erik.schmauss@...el.com>; Wysocki, Rafael J
> > <rafael.j.wysocki@...el.com>; Len Brown <lenb@...nel.org>
> > Cc: Russ Anderson <russ.anderson@....com>; Dimitri Sivanich
> > <dimitri.sivanich@....com>; Ross Zwisler <ross.zwisler@...ux.intel.com>;
> > Williams, Dan J <dan.j.williams@...el.com>; Verma, Vishal L
> > <vishal.l.verma@...el.com>; Jiang, Dave <dave.jiang@...el.com>; linux-
> > acpi@...r.kernel.org; devel@...ica.org; linux-nvdimm@...ts.01.org;
> > linux-kernel@...r.kernel.org
> > Subject: [PATCH 1/1] x86, pmem, acpi: Remove excessive ACPI Large
> > Reference Count warnings
> > 
> > With the Intel BIOS support for 8 processor sockets with a full
> > complement of NVDIMMS potentially installable, and there are empty
> > sockets without NVDIMMS, there is an extremely large amount of the
> > following warnings:
> > 
> > ACPI Warning: Large Reference Count (0x1001) in object ffff99453fc71750,
> > 	Type=0x0A
> > 
> > On a 4 socket system with 4 NVDIMMs there were over 6000 of these
> > warning messages and it has been seem on systems from 4 to 32 sockets.
> > 
> > Through some guidance from the BIOS developers and testing, it appears
> > that simply bumping up the threshold for warnings from 0x1000 to 0x2000
> > eliminates these messages.  Changing them to be ACPI DEBUG messages, or
> > even removing them are other options, but it would then defeat the
> > purpose of the warnings as the problem would effectively be hidden.
> > 
> > Reviewed-by: Dimitri Sivanich <dimitri.sivanich@....com>
> > Tested-by: Russ Anderson <russ.anderson@....com>
> > Signed-off-by: Mike Travis <mike.travis@....com>
> > ---
> >  include/acpi/acconfig.h |    2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > --- linux-4.12.orig/include/acpi/acconfig.h
> > +++ linux-4.12/include/acpi/acconfig.h
> > @@ -123,7 +123,7 @@
> > 
> >  /* Maximum object reference count (detects object deletion issues) */
> > 
> > -#define ACPI_MAX_REFERENCE_COUNT        0x1000
> > +#define ACPI_MAX_REFERENCE_COUNT        0x2000
> > 
> >  /* Default page size for use in mapping memory for operation regions */
> > 
> > 
> > --
> 

-- 
Russ Anderson,  SuperDome Flex Linux Kernel Group Manager
HPE - Hewlett Packard Enterprise (formerly SGI)  rja@....com