linux-kernel - Re: [PATCH v2] sh: prefer _THIS_IP_ to current_text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180801145530.185dab6b47a61842923fc02d@linux-foundation.org>
Date:   Wed, 1 Aug 2018 14:55:30 -0700
From:   Andrew Morton <akpm@...ux-foundation.org>
To:     Nick Desaulniers <ndesaulniers@...gle.com>
Cc:     ysato@...rs.sourceforge.jp, dalias@...c.org,
        linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] sh: prefer _THIS_IP_ to current_text_addr

On Wed,  1 Aug 2018 11:53:31 -0700 Nick Desaulniers <ndesaulniers@...gle.com> wrote:

> As part of the effort to reduce the code duplication between _THIS_IP_
> and current_text_addr(), let's consolidate callers of
> current_text_addr() to use _THIS_IP_.

Why not switch everything to current_text_addr()?  _THIS_IP_ is ugly ;)

Several architectures (s390, sparc, sh, ...) do funky things in their
current_text_addr().  Does the generic kernel.h implementation of
current_text_addr() work OK on those architectures?