linux-kernel - Re: [PATCH net-next] rxrpc: remove redundant variables 'xcall','sp' and 'did

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <15081.1533112094@warthog.procyon.org.uk>
Date:   Wed, 01 Aug 2018 09:28:14 +0100
From:   David Howells <dhowells@...hat.com>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     dhowells@...hat.com, davem@...emloft.net,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        linux-afs@...ts.infradead.org
Subject: Re: [PATCH net-next] rxrpc: remove redundant variables 'xcall','sp' and 'did_discard'

YueHaibing <yuehaibing@...wei.com> wrote:

>  		while (*pp) {
>  			parent = *pp;
> -			xcall = rb_entry(parent, struct rxrpc_call, sock_node);
>  			if (user_call_ID < call->user_call_ID)
>  				pp = &(*pp)->rb_left;
>  			else if (user_call_ID > call->user_call_ID)

No, this is an actual bug.  The if-conditions should be using xcall-> not
call->.

> -		sp = rxrpc_skb(skb);

Yeah, that's fine.

> -	did_discard = true;

Hmmm...  It looks like I intended something with this, but I don't remember
what now.  I think it can be removed.

David