linux-kernel - Re: [PATCH 1/2] staging: erofs: add the missing break in z_erofs_map_blocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ea978a27-efd4-9d58-e4c0-f9d00420304f@huawei.com>
Date:   Wed, 1 Aug 2018 17:19:55 +0800
From:   Gao Xiang <gaoxiang25@...wei.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>
CC:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        <devel@...verdev.osuosl.org>, <yuchao0@...wei.com>,
        <linux-erofs@...ts.ozlabs.org>, <hsiangkao@....com>,
        <linux-kernel@...r.kernel.org>, <weidu.du@...wei.com>,
        <miaoxie@...wei.com>, <chao@...nel.org>
Subject: Re: [PATCH 1/2] staging: erofs: add the missing break in
 z_erofs_map_blocks_iter

Hi Dan,

On 2018/8/1 17:02, Dan Carpenter wrote:
> On Wed, Aug 01, 2018 at 02:38:30PM +0800, Gao Xiang wrote:
>> diff --git a/drivers/staging/erofs/unzip_vle.c b/drivers/staging/erofs/unzip_vle.c
>> index bd2d7a8..6d3ab31 100644
>> --- a/drivers/staging/erofs/unzip_vle.c
>> +++ b/drivers/staging/erofs/unzip_vle.c
>> @@ -1596,10 +1596,10 @@ int z_erofs_map_blocks_iter(struct inode *inode,
>>  	cluster_type = vle_cluster_type(di);
>>  
>>  	switch (cluster_type) {
>> -	case Z_EROFS_VLE_CLUSTER_TYPE_PLAIN:
>> +	case Z_EROFS_VLE_CLUSTER_TYPE_PLAIN:	/* fallthrough */
> This fallthrough comment is in the wrong place.  It should be at the end
> where the break would have been.  Like this:
> 
> 	switch (cluster_type) {
> 	case Z_EROFS_VLE_CLUSTER_TYPE_PLAIN:
> 		frob();
> 		frob();
> 		frob();
> 		/* fallthrough */
> 	case Z_EROFS_VLE_CLUSTER_TYPE_HEAD:
> 		frob();
> 

I am sorry.. I will send a new patch.
Thanks for your reply...

Thanks,
Gao Xiang

> regards,
> dan carpenter
>