linux-kernel - Re: [PATCH] mmc: mxcmmc: Fix missing parentheses and brace

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPDyKFpdfVx4QqOEsBhOrTPp7iVo=qqFr7AFr-e2Sfqef+CtWQ@mail.gmail.com>
Date:   Wed, 1 Aug 2018 11:41:39 +0200
From:   Ulf Hansson <ulf.hansson@...aro.org>
To:     Kees Cook <keescook@...omium.org>
Cc:     Linus Torvalds <torvalds@...ux-foundation.org>,
        Christoph Hellwig <hch@....de>,
        "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mmc: mxcmmc: Fix missing parentheses and brace

On 31 July 2018 at 22:27, Kees Cook <keescook@...omium.org> wrote:
> On Mon, Jul 16, 2018 at 3:11 AM, Ulf Hansson <ulf.hansson@...aro.org> wrote:
>> On 12 July 2018 at 21:59, Kees Cook <keescook@...omium.org> wrote:
>>> Looks like the adjusted syntax wasn't fully build tested. This fixes
>>> failures with powerpc builds:
>>>
>>> drivers/mmc/host/mxcmmc.c: In function ‘mxcmci_swap_buffers’:
>>> drivers/mmc/host/mxcmmc.c:296:51: error: expected ‘)’ before ‘;’ token
>>>    void *buf = kmap_atomic(sg_page(sg) + sg->offset;
>>>                                                    ^
>>> drivers/mmc/host/mxcmmc.c:299:1: error: expected ‘,’ or ‘;’ before ‘}’ token
>>>  }
>>>  ^
>>>
>>> Fixes: b189e7589f6d3 ("mmc: mxcmmc: handle highmem pages")
>>> Signed-off-by: Kees Cook <keescook@...omium.org>
>>
>> Thanks, applied for fixes!
>
> I just checked again, and while I see this in linux-next, I would
> expect this to be in 4.18, since this fixes a 4.18-introduced build
> failure for some PPC configurations. Can this please be included in
> 4.18?

Yes it will, I was just about to create a PR for it.

However, I have deliberately slowed down the pace of sending fixes to
Linus, because of trying to achieve a somewhat better test coverage.

If you want to test the latest 4.18 rcs with pending fixes, we have
the pending-fixes branch in Stephen's next tree.

[...]

Kind regards
Uffe