linux-kernel - RE: [PATCH net-next] qed: Make some functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <MWHPR07MB34711F11A6E418F24A30B27B962D0@MWHPR07MB3471.namprd07.prod.outlook.com>
Date:   Wed, 1 Aug 2018 10:05:18 +0000
From:   "Bolotin, Denis" <Denis.Bolotin@...ium.com>
To:     YueHaibing <yuehaibing@...wei.com>,
        "davem@...emloft.net" <davem@...emloft.net>,
        "Elior, Ariel" <Ariel.Elior@...ium.com>,
        Dept-Eng Everest Linux L2 <Dept-EngEverestLinuxL2@...ium.com>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>
Subject: RE: [PATCH net-next] qed: Make some functions static

> From: YueHaibing <yuehaibing@...wei.com>
> Sent: Tuesday, July 31, 2018 5:13 PM
> To: davem@...emloft.net; Elior, Ariel <Ariel.Elior@...ium.com>; Dept-Eng
> Everest Linux L2 <Dept-EngEverestLinuxL2@...ium.com>
> Cc: linux-kernel@...r.kernel.org; netdev@...r.kernel.org; YueHaibing
> <yuehaibing@...wei.com>
> Subject: [PATCH net-next] qed: Make some functions static
> 
> Fixes the following sparse warning:
> 
> drivers/net/ethernet/qlogic/qed/qed_cxt.c:1534:6: warning: symbol
> 'qed_cm_init_pf' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_dev.c:233:4: warning: symbol
> 'qed_init_qm_get_num_tcs' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_dev.c:238:5: warning: symbol
> 'qed_init_qm_get_num_vfs' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_dev.c:246:5: warning: symbol
> 'qed_init_qm_get_num_pf_rls' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_dev.c:264:5: warning: symbol
> 'qed_init_qm_get_num_vports' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_dev.c:276:5: warning: symbol
> 'qed_init_qm_get_num_pqs' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_mcp.c:573:5: warning: symbol
> 'qed_mcp_nvm_wr_cmd' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_mcp.c:3012:1: warning: symbol
> '__qed_mcp_resc_lock' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_dcbx.c:870:6: warning: symbol
> 'qed_dcbx_aen' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_debug.c:7841:5: warning: symbol
> 'qed_dbg_nvm_image_length' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_debug.c:7857:5: warning: symbol
> 'qed_dbg_nvm_image' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_sriov.c:675:6: warning: symbol
> '_qed_iov_pf_sanity_check' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_sriov.c:690:6: warning: symbol
> 'qed_iov_pf_sanity_check' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_sriov.c:3982:6: warning: symbol
> 'qed_iov_pf_get_pending_events' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_vf.c:172:5: warning: symbol
> '_qed_vf_pf_release' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_rdma.c:137:5: warning: symbol
> 'qed_rdma_get_sb_id' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_rdma.c:709:5: warning: symbol
> 'qed_rdma_stop' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_ll2.c:161:6: warning: symbol
> 'qed_ll2b_complete_rx_packet' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_roce.c:160:6: warning: symbol
> 'qed_roce_free_cid_pair' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_iwarp.c:380:12: warning: symbol
> 'iwarp_state_names' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_iwarp.c:946:1: warning: symbol
> 'qed_iwarp_parse_private_data' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_iwarp.c:971:1: warning: symbol
> 'qed_iwarp_mpa_reply_arrived' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_iwarp.c:2504:1: warning: symbol
> 'qed_iwarp_ll2_slowpath' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_iwarp.c:2806:6: warning: symbol
> 'qed_iwarp_qp_in_error' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_iwarp.c:2827:6: warning: symbol
> 'qed_iwarp_exception_received' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_iwarp.c:2958:1: warning: symbol
> 'qed_iwarp_connect_complete' was not declared. Should it be static?
> drivers/net/ethernet/qlogic/qed/qed_iscsi.c:876:6: warning: symbol
> 'qed_iscsi_free_connection' was not declared. Should it be static?
> 
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Thanks
Acked-by: Denis Bolotin <Denis.Bolotin@...ium.com>