linux-kernel - Re: [PATCH v5] staging: rts5208: add error handling into rtsx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHp75VeSr-dDC+BvvTi1f2JBDL0UB31O=umatKE4y=0HQ4_8UQ@mail.gmail.com>
Date:   Wed, 1 Aug 2018 15:18:58 +0300
From:   Andy Shevchenko <andy.shevchenko@...il.com>
To:     Anton Vasilyev <vasilyev@...ras.ru>
Cc:     Dan Carpenter <dan.carpenter@...cle.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sinan Kaya <okaya@...eaurora.org>,
        Johannes Thumshirn <jthumshirn@...e.de>,
        Gaurav Pathak <gauravpathak129@...il.com>,
        Hannes Reinecke <hare@...e.de>, devel@...verdev.osuosl.org,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ldv-project@...uxtesting.org
Subject: Re: [PATCH v5] staging: rts5208: add error handling into rtsx_probe

On Wed, Aug 1, 2018 at 2:55 PM, Anton Vasilyev <vasilyev@...ras.ru> wrote:
> If rtsx_probe() fails to allocate dev->chip, then release_everything()
> will crash on uninitialized dev->cmnd_ready complete.
>
> Patch adds an error handling into rtsx_probe.
> Found by Linux Driver Verification project (linuxtesting.org).

Have you based your change on staging-next?

Seems not. You need to rebase and resend.

-- 
With Best Regards,
Andy Shevchenko