lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 1 Aug 2018 04:38:41 +0000 From: "Y.b. Lu" <yangbo.lu@....com> To: David Miller <davem@...emloft.net> CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Madalin-cristian Bucur <madalin.bucur@....com>, "richardcochran@...il.com" <richardcochran@...il.com>, "robh+dt@...nel.org" <robh+dt@...nel.org>, "shawnguo@...nel.org" <shawnguo@...nel.org>, "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>, "linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: RE: [PATCH 3/3] ptp_qoriq: convert to use module parameters for initialization Hi David, > -----Original Message----- > From: David Miller [mailto:davem@...emloft.net] > Sent: Tuesday, July 31, 2018 12:26 AM > To: Y.b. Lu <yangbo.lu@....com> > Cc: netdev@...r.kernel.org; Madalin-cristian Bucur > <madalin.bucur@....com>; richardcochran@...il.com; robh+dt@...nel.org; > shawnguo@...nel.org; devicetree@...r.kernel.org; > linuxppc-dev@...ts.ozlabs.org; linux-arm-kernel@...ts.infradead.org; > linux-kernel@...r.kernel.org > Subject: Re: [PATCH 3/3] ptp_qoriq: convert to use module parameters for > initialization > > From: Yangbo Lu <yangbo.lu@....com> > Date: Mon, 30 Jul 2018 18:01:54 +0800 > > > +static unsigned int cksel = DEFAULT_CKSEL; module_param(cksel, uint, > > +0644); MODULE_PARM_DESC(cksel, "Select reference clock"); > > + > > +static unsigned int clk_src; > > +module_param(clk_src, uint, 0644); > > +MODULE_PARM_DESC(clk_src, "Reference clock frequency (if clocks > > +property not provided in dts)"); > > + > > +static unsigned int tmr_prsc = 2; > > +module_param(tmr_prsc, uint, 0644); > > +MODULE_PARM_DESC(tmr_prsc, "Output clock division/prescale factor"); > > + > > +static unsigned int tmr_fiper1 = 1000000000; module_param(tmr_fiper1, > > +uint, 0644); MODULE_PARM_DESC(tmr_fiper1, "Desired fixed interval > > +pulse period (ns)"); > > + > > +static unsigned int tmr_fiper2 = 100000; module_param(tmr_fiper2, > > +uint, 0644); MODULE_PARM_DESC(tmr_fiper2, "Desired fixed interval > > +pulse period (ns)"); > > Sorry, there is no way I am every applying something like this. Module > parameters are to be avoided at all costs. > > And you don't need it here, you have DTS, please use it. > > You are required to support the existing DTS cases, in order to avoid breaking > things, anyways. [Y.b. Lu] I get your point. Will drop module_param method. Thanks a lot for your suggestion.
Powered by blists - more mailing lists