[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <41gMDG3RdFz9s3q@ozlabs.org>
Date: Wed, 1 Aug 2018 15:23:58 +1000 (AEST)
From: Michael Ellerman <patch-notifications@...erman.id.au>
To: Finn Thain <fthain@...egraphics.com.au>,
Benjamin Herrenschmidt <benh@...nel.crashing.org>
Cc: Michael Schmitz <schmitzmic@...il.com>,
linux-m68k@...ts.linux-m68k.org, linuxppc-dev@...ts.ozlabs.org,
linux-kernel@...r.kernel.org
Subject: Re: [v4,01/11] macintosh/via-pmu: Fix section mismatch warning
On Mon, 2018-07-02 at 08:21:18 UTC, Finn Thain wrote:
> The pmu_init() function has the __init qualifier, but the ops struct
> that holds a pointer to it does not. This causes a build warning.
> The driver works fine because the pointer is only dereferenced early.
>
> The function is so small that there's negligible benefit from using
> the __init qualifier. Remove it to fix the warning, consistent with
> the other ADB drivers.
>
> Tested-by: Stan Johnson <userm57@...oo.com>
> Signed-off-by: Finn Thain <fthain@...egraphics.com.au>
> Reviewed-by: Geert Uytterhoeven <geert@...ux-m68k.org>
Series applied to powerpc next, thanks.
https://git.kernel.org/powerpc/c/73f4447d43484224d7abfba0d9468d
cheers
Powered by blists - more mailing lists