linux-kernel - Re: [PATCH 11/25] selftests/ftrace: Improve kprobe on module testcase to load/unload module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20180802162258.e038d6b1114f6c3c9e2dc238@kernel.org>
Date:   Thu, 2 Aug 2018 16:22:58 +0900
From:   Masami Hiramatsu <mhiramat@...nel.org>
To:     Masami Hiramatsu <mhiramat@...nel.org>
Cc:     Shuah Khan <shuah@...nel.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Ingo Molnar <mingo@...hat.com>,
        linux-kselftest@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 11/25] selftests/ftrace: Improve kprobe on module
 testcase to load/unload module

On Thu, 2 Aug 2018 10:02:40 +0900
Masami Hiramatsu <mhiramat@...nel.org> wrote:

> On Fri, 27 Jul 2018 21:15:08 +0900
> Masami Hiramatsu <mhiramat@...nel.org> wrote:
> 
> > --- a/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_module.tc
> > +++ b/tools/testing/selftests/ftrace/test.d/kprobe/kprobe_module.tc
> > @@ -4,11 +4,18 @@
> >  
> >  [ -f kprobe_events ] || exit_unsupported # this is configurable
> >  
> > +rmmod trace-printk ||:
> > +if ! modprobe trace-printk.ko ; then
> > +  echo "No trace-printk sample module - please make CONFIG_SAMPLE_TRACE_PRINTK=
> > +m"
> > +  exit_unresolved;
> > +fi
> > +
> > +MOD=trace_printk
> > +FUNC=trace_printk_irq_work
> 
> Hmm, this caused a problem with CONFIG_KPROBE_EVENTS_ON_NOTRACE=n.
> However, as far as I can see, the trace_printk_irq_work() is not
> marked as notrace...

Ah, I found this was caused by my prevent probe on notrace patch.
I was a bit too greedy to check out-of-range probes in it.
I'll fix that.

Thank you,

-- 
Masami Hiramatsu <mhiramat@...nel.org>