linux-kernel - Re: [PATCH 2/8] staging: gasket: core: print driver version code at registration time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Aug 2018 10:57:06 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Todd Poynor <toddpoynor@...il.com>
Cc:     Rob Springer <rspringer@...gle.com>,
        John Joseph <jnjoseph@...gle.com>,
        Ben Chan <benchan@...omium.org>, devel@...verdev.osuosl.org,
        Todd Poynor <toddpoynor@...gle.com>,
        Dmitry Torokhov <dtor@...omium.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/8] staging: gasket: core: print driver version code at
 registration time

On Thu, Aug 02, 2018 at 01:42:39AM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@...gle.com>
> 
> Print the driver version code in the kernel log at gasket driver
> registration time for informational purposes.  Add "gasket:" prefix to
> make clear it is the gasket framework logging this information.
> 
> Signed-off-by: Todd Poynor <toddpoynor@...gle.com>
> ---
>  drivers/staging/gasket/gasket_core.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c
> index f76f4a0ecbac6..e550c9060dcd2 100644
> --- a/drivers/staging/gasket/gasket_core.c
> +++ b/drivers/staging/gasket/gasket_core.c
> @@ -1759,8 +1759,9 @@ int gasket_register_device(const struct gasket_driver_desc *driver_desc)
>  	}
>  	mutex_unlock(&g_mutex);
>  
> -	pr_info("Loaded %s driver, framework version %s\n",
> -		driver_desc->name, GASKET_FRAMEWORK_VERSION);
> +	pr_info("gasket: Loaded %s driver version %s, framework version %s\n",
> +		driver_desc->name, driver_desc->driver_version,
> +		GASKET_FRAMEWORK_VERSION);

This is what pr_fmt is for, please just set that properly and all will
be fine.

But really, just delete this line, drivers, if all is going well, should
not emit any noise to the kernel log.  Especially for something like
doing a 'modprobe', which is really what is happening here.  Just drop
the noisy messages please.

Also, GASKET_FRAMEWORK_VERSION means nothing now, it needs to be dropped :)

thanks,

greg k-h