linux-kernel - Re: [PATCH 8/8] Revert "staging: gasket: core: hold reference to pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180802090008.GE23992@kroah.com>
Date:   Thu, 2 Aug 2018 11:00:08 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Todd Poynor <toddpoynor@...il.com>
Cc:     Rob Springer <rspringer@...gle.com>,
        John Joseph <jnjoseph@...gle.com>,
        Ben Chan <benchan@...omium.org>, devel@...verdev.osuosl.org,
        Todd Poynor <toddpoynor@...gle.com>,
        Dmitry Torokhov <dtor@...omium.org>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/8] Revert "staging: gasket: core: hold reference to
 pci_dev while used"

On Thu, Aug 02, 2018 at 01:42:45AM -0700, Todd Poynor wrote:
> From: Todd Poynor <toddpoynor@...gle.com>
> 
> There's no need to take an additional reference on the pci_dev structure
> for the pointer copy saved in gasket data structures.
> 
> This reverts commit 8dd8a48b9a7dae5493494a8603adddfdf1914716.

Hint, when dealing with sha1 numbers in the kernel, we like the
following format to make it a bit easier to understand:
	8dd8a48b9a7d ("staging: gasket: core: hold reference to pci_dev while used")
which can be generated by doing:
	git show -s --abbrev-commit --abbrev=12 --pretty=format:"%h (\"%s\")%n"

Can you fix this up and resend?

thanks,

greg k-h