linux-kernel - Re: [PATCH] fix vibrations on Droid 4

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20180802105535.2fvggxsma22usrfr@earth.universe>
Date:   Thu, 2 Aug 2018 12:55:35 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Pavel Machek <pavel@....cz>
Cc:     Tony Lindgren <tony@...mide.com>,
        kernel list <linux-kernel@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>,
        linux-omap@...r.kernel.org, nekit1000@...il.com, mpartap@....net,
        merlijn@...zup.org
Subject: Re: [PATCH] fix vibrations on Droid 4

Hi,

On Wed, Aug 01, 2018 at 10:28:21PM +0200, Pavel Machek wrote:
> Vibration GPIOs don't have anything to do with wakeup. Move it to
> normal section; this fixes vibrations on Droid 4.
>     
> Signed-off-by: Pavel Machek <pavel@....cz>
> 
> diff --git a/arch/arm/boot/dts/omap4-droid4-xt894.dts b/arch/arm/boot/dts/omap4-droid4-xt894.dts
> index c27fc87..7b82179 100644

Reviewed-by: Sebastian Reichel <sebastian.reichel@...labora.co.uk>

-- Sebastian

> --- a/arch/arm/boot/dts/omap4-droid4-xt894.dts
> +++ b/arch/arm/boot/dts/omap4-droid4-xt894.dts
> @@ -646,15 +646,6 @@
>  		OMAP4_IOPAD(0x10c, PIN_INPUT | MUX_MODE1)	/* abe_mcbsp3_fsx */
>  		>;
>  	};
> -};
> -
> -&omap4_pmx_wkup {
> -	usb_gpio_mux_sel2: pinmux_usb_gpio_mux_sel2_pins {
> -		/* gpio_wk0 */
> -		pinctrl-single,pins = <
> -		OMAP4_IOPAD(0x040, PIN_OUTPUT_PULLDOWN | MUX_MODE3)
> -		>;
> -	};
>  
>  	vibrator_direction_pin: pinmux_vibrator_direction_pin {
>  		pinctrl-single,pins = <
> @@ -669,6 +660,15 @@
>  	};
>  };
>  
> +&omap4_pmx_wkup {
> +	usb_gpio_mux_sel2: pinmux_usb_gpio_mux_sel2_pins {
> +		/* gpio_wk0 */
> +		pinctrl-single,pins = <
> +		OMAP4_IOPAD(0x040, PIN_OUTPUT_PULLDOWN | MUX_MODE3)
> +		>;
> +	};
> +};
> +
>  /*
>   * As uart1 is wired to mdm6600 with rts and cts, we can use the cts pin for
>   * uart1 wakeirq.
> 
> -- 
> (english) http://www.livejournal.com/~pavelmachek
> (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)