linux-kernel - Re: [PATCH 1/1] selftest/net: fix protocol family to work for IPv4.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bd39eee1-ff9f-db4e-2948-2cb9a7a651f7@gmail.com>
Date:   Thu, 2 Aug 2018 06:03:13 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Maninder Singh <maninder1.s@...sung.com>, davem@...emloft.net,
        shuahkh@....samsung.com
Cc:     netdev@...r.kernel.org, linux-api@...r.kernel.org,
        linux-kernel@...r.kernel.org, edumazet@...gle.com,
        pankaj.m@...sung.com, a.sahrawat@...sung.com,
        Vaneet Narang <v.narang@...sung.com>
Subject: Re: [PATCH 1/1] selftest/net: fix protocol family to work for IPv4.



On 08/02/2018 02:57 AM, Maninder Singh wrote:
> use actual protocol family passed by user rather than hardcoded
> AF_INTE6 to cerate sockets.
> current code is not working for IPv4.
> 
> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> Signed-off-by: Vaneet Narang <v.narang@...sung.com>
> ---
>  tools/testing/selftests/net/tcp_mmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/net/tcp_mmap.c b/tools/testing/selftests/net/tcp_mmap.c
> index 77f7627..e8c5dff 100644
> --- a/tools/testing/selftests/net/tcp_mmap.c
> +++ b/tools/testing/selftests/net/tcp_mmap.c
> @@ -402,7 +402,7 @@ int main(int argc, char *argv[])
>  		exit(1);
>  	}
>  
> -	fd = socket(AF_INET6, SOCK_STREAM, 0);
> +	fd = socket(cfg_family, SOCK_STREAM, 0);
>  	if (fd == -1) {
>  		perror("socket");
>  		exit(1);
> 


Darn, someone spotted my hidden attempt to kill IPv4 ;)

Reviewed-by: Eric Dumazet <edumazet@...gle.com>