linux-kernel - Re: [PATCH] lightnvm: remove dependencies on BLK_DEV

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <B899AED5-11D4-4ACB-B10B-5C080AC9B882@cnexlabs.com>
Date:   Thu, 2 Aug 2018 13:18:53 +0000
From:   Javier Gonzalez <javier@...xlabs.com>
To:     Matias Bjørling <mb@...htnvm.io>
CC:     "Konopko, Igor J" <igor.j.konopko@...el.com>,
        "marcin.dziegielewski@...el.com" <marcin.dziegielewski@...el.com>,
        Hans Holmberg <hans.holmberg@...xlabs.com>,
        Heiner Litz <hlitz@...c.edu>,
        Young Tack Tack Jin <youngtack.jin@...cuitblvd.com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lightnvm: remove dependencies on BLK_DEV_NVME and PCI

> On 2 Aug 2018, at 13.06, Matias Bjørling <mb@...htnvm.io> wrote:
> 
> No need to force NVMe device driver to be compiled in if the
> lightnvm subsystem is selected. Also no need for PCI to be selected
> as well, as it would be selected by the device driver that hooks into
> the subsystem.
> 
> Signed-off-by: Matias Bjørling <mb@...htnvm.io>
> ---
> drivers/lightnvm/Kconfig | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/lightnvm/Kconfig b/drivers/lightnvm/Kconfig
> index 439bf90d084d..a872cd720967 100644
> --- a/drivers/lightnvm/Kconfig
> +++ b/drivers/lightnvm/Kconfig
> @@ -4,8 +4,7 @@
> 
> menuconfig NVM
> 	bool "Open-Channel SSD target support"
> -	depends on BLOCK && PCI
> -	select BLK_DEV_NVME
> +	depends on BLOCK
> 	help
> 	  Say Y here to get to enable Open-channel SSDs.
> 
> --
> 2.11.0

Looks like a good dependency cleanup. Though the nvme driver is the
only one that hooks into LigthNVM today, so it will have to be compiled
anyway.

Reviewed-by: Javier González <javier@...xlabs.com>


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)