linux-kernel - Re: [PATCH] nfsd: use true and false for boolean values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180802133445.GB30706@fieldses.org>
Date:   Thu, 2 Aug 2018 09:34:45 -0400
From:   "J. Bruce Fields" <bfields@...ldses.org>
To:     "Gustavo A. R. Silva" <gustavo@...eddedor.com>
Cc:     Jeff Layton <jlayton@...nel.org>, linux-nfs@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfsd: use true and false for boolean values

OK, applied for for-4.19, thanks.--b.

On Wed, Aug 01, 2018 at 07:44:05PM -0500, Gustavo A. R. Silva wrote:
> Return statements in functions returning bool should use true or false
> instead of an integer value.
> 
> This issue was detected with the help of Coccinelle.
> 
> Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com>
> ---
>  fs/nfsd/nfsfh.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/nfsd/nfsfh.c b/fs/nfsd/nfsfh.c
> index a008e76..b319080 100644
> --- a/fs/nfsd/nfsfh.c
> +++ b/fs/nfsd/nfsfh.c
> @@ -451,7 +451,7 @@ static bool fsid_type_ok_for_exp(u8 fsid_type, struct svc_export *exp)
>  	switch (fsid_type) {
>  	case FSID_DEV:
>  		if (!old_valid_dev(exp_sb(exp)->s_dev))
> -			return 0;
> +			return false;
>  		/* FALL THROUGH */
>  	case FSID_MAJOR_MINOR:
>  	case FSID_ENCODE_DEV:
> @@ -461,13 +461,13 @@ static bool fsid_type_ok_for_exp(u8 fsid_type, struct svc_export *exp)
>  	case FSID_UUID8:
>  	case FSID_UUID16:
>  		if (!is_root_export(exp))
> -			return 0;
> +			return false;
>  		/* fall through */
>  	case FSID_UUID4_INUM:
>  	case FSID_UUID16_INUM:
>  		return exp->ex_uuid != NULL;
>  	}
> -	return 1;
> +	return true;
>  }
>  
>  
> -- 
> 2.7.4