linux-kernel - Re: [PATCH 02/12] i2c: designware-master: use core to detect 'no zero length' quirk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db46f7ba-0627-eb0b-9a93-40f26a82b0bf@linux.intel.com>
Date:   Thu, 2 Aug 2018 17:00:59 +0300
From:   Jarkko Nikula <jarkko.nikula@...ux.intel.com>
To:     Wolfram Sang <wsa+renesas@...g-engineering.com>,
        linux-i2c@...r.kernel.org
Cc:     linux-renesas-soc@...r.kernel.org,
        Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
        Mika Westerberg <mika.westerberg@...ux.intel.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 02/12] i2c: designware-master: use core to detect 'no zero
 length' quirk

On 07/23/2018 11:26 PM, Wolfram Sang wrote:
> And don't reimplement in the driver.
> 
> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> ---
> 
> Only build tested.
> 
>   drivers/i2c/busses/i2c-designware-master.c | 12 +++++-------
>   1 file changed, 5 insertions(+), 7 deletions(-)
> 
I tested this with patch 1 and I like it since with these patches the 
test is done before firing up the HW, waiting for an interrupt and then 
see the length is invalid for us.

i2ctransfer -f 8 r0@...0

Before (with i2c_designware debugging on):
[   15.607283] i2c_designware i2c_designware.1: i2c_dw_xfer: msgs: 1
[   15.711988] i2c_designware i2c_designware.1: enabled=0x1 stat=0x10
[   15.712002] i2c_designware i2c_designware.1: i2c_dw_xfer_msg: invalid 
message length
Error: Sending messages failed: Invalid argument

After:
[   25.838661] i2c i2c-8: adapter quirk: no zero length (addr 0x0010, 
size 0, read)
Error: Sending messages failed: Operation not supported

Tested-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>
Acked-by: Jarkko Nikula <jarkko.nikula@...ux.intel.com>