linux-kernel - Re: [PATCH] staging: mt29f_spinand: fix memory leak while programming pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 2 Aug 2018 10:08:08 +0800
From:   Jheng-Jhong Wu <goodwater.wu@...il.com>
To:     dan.carpenter@...cle.com
Cc:     devel@...verdev.osuosl.org, gregkh@...uxfoundation.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging: mt29f_spinand: fix memory leak while programming pages

Dear
Dan Carpenter,

I know what   you wrote,   but   before   device   is   removed   and
 freed   memory   automatically,   programming   pages may   do   many
 many   times.
Assume   we   erase and rewrite a  large  part  of  the   flash,   then
spinand_program_page()   might exhaust   memory if memory is not large
enough.
In   fact,   OOM   indeed occured  when   I   tested  programming
 multi-pages by mtd_debug tool.
If   OOM   was not   caused   by   devm_kzalloc() in
spinand_program_page(),   what   may   exhaust   memory?

*Best Regards,*
*─────────────────────────*
*Jheng-Jhong Wu (Victor Wu)*
*E-mail: goodwater.wu@...il.com <goodwater.wu@...il.com>*
*─────────────────────────*

Dan Carpenter <dan.carpenter@...cle.com> 於 2018年8月1日 週三 下午7:45寫道：

> devm_ resources are freed automatically when the device is removed.
> The name devm_ stands for "device" and "managed".
>
> regards,
> dan carpenter
>
>

Content of type "text/html" skipped