linux-kernel - Re: [PATCH] lightnvm: pblk: take write semaphore on metadata

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <E290F3A7-B98F-498C-9969-B7584F340B9A@cnexlabs.com>
Date:   Thu, 2 Aug 2018 16:01:32 +0000
From:   Javier Gonzalez <javier@...xlabs.com>
To:     Jens Axboe <axboe@...nel.dk>
CC:     Javier González <javier@...igon.com>,
        "mb@...htnvm.io" <mb@...htnvm.io>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lightnvm: pblk: take write semaphore on metadata



> On 2 Aug 2018, at 17.57, Jens Axboe <axboe@...nel.dk> wrote:
> 
>> On 8/2/18 7:47 AM, Javier González wrote:
>> Take the write semaphore on metadata I/Os too.
> 
> I'm going to nit pick a little bit here, but this isn't a good
> changelog at all. A good changelog tells you _why_ a change is
> made, not how it's made. Your commit message doesn't really tell
> me anything that I can't easily glean from looking at the patch.
> 
> A good commit message would tell me _why_ we are now also
> grabbing the write sem for metadata.
> 
> -- 
> Jens Axboe
> 

You’re right. I’ll fix the commit message and resend tomorrow. 

Javier