linux-kernel - Re: [PATCH] kernel/module: Use kmemdup to replace kmalloc+memcpy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180802161758.meijhtmvdhz4qfup@linux-8ccs>
Date:   Thu, 2 Aug 2018 18:17:58 +0200
From:   Jessica Yu <jeyu@...nel.org>
To:     zhong jiang <zhongjiang@...wei.com>
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] kernel/module: Use kmemdup to replace kmalloc+memcpy

+++ zhong jiang [01/08/18 00:56 +0800]:
>we prefer to the kmemdup rather than kmalloc+memcpy. so just
>replace them.
>
>Signed-off-by: zhong jiang <zhongjiang@...wei.com>

Applied, thanks.

Jessica

>---
> kernel/module.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/kernel/module.c b/kernel/module.c
>index 20344e4..6746c85 100644
>--- a/kernel/module.c
>+++ b/kernel/module.c
>@@ -2057,21 +2057,19 @@ static int copy_module_elf(struct module *mod, struct load_info *info)
>
> 	/* Elf section header table */
> 	size = sizeof(*info->sechdrs) * info->hdr->e_shnum;
>-	mod->klp_info->sechdrs = kmalloc(size, GFP_KERNEL);
>+	mod->klp_info->sechdrs = kmemdup(info->sechdrs, size, GFP_KERNEL);
> 	if (mod->klp_info->sechdrs == NULL) {
> 		ret = -ENOMEM;
> 		goto free_info;
> 	}
>-	memcpy(mod->klp_info->sechdrs, info->sechdrs, size);
>
> 	/* Elf section name string table */
> 	size = info->sechdrs[info->hdr->e_shstrndx].sh_size;
>-	mod->klp_info->secstrings = kmalloc(size, GFP_KERNEL);
>+	mod->klp_info->secstrings = kmemdup(info->secstrings, size, GFP_KERNEL);
> 	if (mod->klp_info->secstrings == NULL) {
> 		ret = -ENOMEM;
> 		goto free_sechdrs;
> 	}
>-	memcpy(mod->klp_info->secstrings, info->secstrings, size);
>
> 	/* Elf symbol section index */
> 	symndx = info->index.sym;
>-- 
>1.7.12.4
>