linux-kernel - Re: [PATCH] inet/connection_sock: prefer _THIS_IP_ to current_text

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKwvOd=oN_ajFa4phMdz_dzjMD2-knzzdh3rgHWHxGPhwAin-A@mail.gmail.com>
Date:   Thu, 2 Aug 2018 10:07:30 -0700
From:   Nick Desaulniers <ndesaulniers@...gle.com>
To:     "David S. Miller" <davem@...emloft.net>
Cc:     Nathan Chancellor <natechancellor@...il.com>,
        netdev@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] inet/connection_sock: prefer _THIS_IP_ to current_text_addr

On Wed, Aug 1, 2018 at 6:42 PM David Miller <davem@...emloft.net> wrote:
>
> From: Nick Desaulniers <ndesaulniers@...gle.com>
> Date: Wed,  1 Aug 2018 14:57:59 -0700
>
> > -                      sk, what, when, current_text_addr());
> > +                      sk, what, when, (void *)_THIS_IP_);
>
> Is a fugly macro in all caps really better than a function()?
>
> I'm really surprised that _THIS_IP_ is being chosen over
> current_text_addr(), seriously.

See: https://lkml.org/lkml/2018/8/1/1689

I'm happy to rename it on your suggestion, after we've consolidated them.

-- 
Thanks,
~Nick Desaulniers