linux-kernel - Re: [PATCH V2 2/2] blk-mq: fix blk_mq_tagset_busy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f5d30bf747641778164335a64255bd7a027bc4c.camel@wdc.com>
Date:   Thu, 2 Aug 2018 18:46:52 +0000
From:   Bart Van Assche <Bart.VanAssche@....com>
To:     "ming.lei@...hat.com" <ming.lei@...hat.com>,
        "axboe@...nel.dk" <axboe@...nel.dk>
CC:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "jthumshirn@...e.de" <jthumshirn@...e.de>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "hch@....de" <hch@....de>,
        "linux@...ck-us.net" <linux@...ck-us.net>,
        "martin.petersen@...cle.com" <martin.petersen@...cle.com>,
        "broonie@...nel.org" <broonie@...nel.org>,
        "matthew.hart@...aro.org" <matthew.hart@...aro.org>,
        "linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
        "josef@...icpanda.com" <josef@...icpanda.com>,
        "john.garry@...wei.com" <john.garry@...wei.com>,
        "hare@...e.com" <hare@...e.com>,
        "James.Bottomley@...senpartnership.com" 
        <James.Bottomley@...senpartnership.com>
Subject: Re: [PATCH V2 2/2] blk-mq: fix blk_mq_tagset_busy_iter

On Fri, 2018-08-03 at 01:49 +0800, Ming Lei wrote:
> Commit d250bf4e776ff09d5("blk-mq: only iterate over inflight requests
> in blk_mq_tagset_busy_iter") uses 'blk_mq_rq_state(rq) == MQ_RQ_IN_FLIGHT'
> to replace 'blk_mq_request_started(req)', this way is wrong, and causes
> lots of test system hang during booting.
> 
> Fix the issue by using blk_mq_request_started(req) inside bt_tags_iter().

That's a good catch. Hence:

Reviewed-by: Bart Van Assche <bart.vanassche@....com>