linux-kernel - Re: [PATCH v1 1/1] gpio: mmio: add inverted direction get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdYOiJhqXyYpRDSD5is=A7-7LEyUwJp2HtpYqbYGR9d5UQ@mail.gmail.com>
Date:   Fri, 3 Aug 2018 01:34:31 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     tmaimon77@...il.com
Cc:     "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>
Subject: Re: [PATCH v1 1/1] gpio: mmio: add inverted direction get_set io support

On Mon, Jul 30, 2018 at 11:34 AM Tomer Maimon <tmaimon77@...il.com> wrote:

> Add get_set_inv_dir and get_set_multiple_inv_dir I/O functions
> to call the data register when the dirction is input and
> set register when the direction is output.
> the functions will linked to the I/O get functions if the user set
> BGPIOF_INVERTED_REG_DIR flag in the bgpio initialization.
>
> Signed-off-by: Tomer Maimon <tmaimon77@...il.com>

I think you uncovered a bug. This is however not the best fix IMO.

Sorry for not understanding the issue at first, I am sometimes
pretty slow in the head. :(

I'm sending a patch that I hope fixes the real problem in an
elegant way, and makes it possible to just define dirin and
BGPIOF_READ_OUTPUT_REG_SET.

Yours,
Linus Walleij