linux-kernel - Re: [PATCH] media: platform: cros-ec-cec: fix dependency on MFD_CROS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 3 Aug 2018 08:29:26 +0200
From:   Hans Verkuil <hverkuil@...all.nl>
To:     Mauro Carvalho Chehab <mchehab+samsung@...nel.org>,
        Arnd Bergmann <arnd@...db.de>
Cc:     Lee Jones <lee.jones@...aro.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Hans Verkuil <hans.verkuil@...co.com>,
        Jacob Chen <jacob-chen@...wrt.com>,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: platform: cros-ec-cec: fix dependency on
 MFD_CROS_EC

On 08/03/2018 12:58 AM, Mauro Carvalho Chehab wrote:
> Em Tue, 24 Jul 2018 11:35:59 +0200
> Arnd Bergmann <arnd@...db.de> escreveu:
> 
>> Without the MFD driver, we run into a link error:
> 
> Weird... I'm not seeing this driver at the media tree... was it merged via
> some other tree?

Yes, it's going via the mfd subsystem. This driver touched on the mfd, drm and
media subsystems, in the end it was decided to let the mfd subsystem take this
since it had the most impact on that subsystem.

Regards,

	Hans

> 
>>
>> drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_transmit':
>> cros-ec-cec.c:(.text+0x474): undefined reference to `cros_ec_cmd_xfer_status'
>> drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_set_log_addr':
>> cros-ec-cec.c:(.text+0x60b): undefined reference to `cros_ec_cmd_xfer_status'
>> drivers/media/platform/cros-ec-cec/cros-ec-cec.o: In function `cros_ec_cec_adap_enable':
>> cros-ec-cec.c:(.text+0x77d): undefined reference to `cros_ec_cmd_xfer_status'
>>
>> As we can compile-test all the dependency, the extra '| COMPILE_TEST' is
>> not needed to get the build coverage, and we can simply turn MFD_CROS_EC
>> into a hard dependency to make it build in all configurations.
>>
>> Fixes: cd70de2d356e ("media: platform: Add ChromeOS EC CEC driver")
>> Signed-off-by: Arnd Bergmann <arnd@...db.de>
>> ---
>>  drivers/media/platform/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
>> index 92b182da8e4d..018fcbed82e4 100644
>> --- a/drivers/media/platform/Kconfig
>> +++ b/drivers/media/platform/Kconfig
>> @@ -535,7 +535,7 @@ if CEC_PLATFORM_DRIVERS
>>  
>>  config VIDEO_CROS_EC_CEC
>>  	tristate "ChromeOS EC CEC driver"
>> -	depends on MFD_CROS_EC || COMPILE_TEST
>> +	depends on MFD_CROS_EC
>>  	select CEC_CORE
>>  	select CEC_NOTIFIER
>>  	---help---
> 
> 
> 
> Thanks,
> Mauro
>