linux-kernel - Re: [PATCH -next] drm/vkms: Fix the error handling in vkms

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20180803000838.ku2lgy4hakcgqc6o@smtp.gmail.com>
Date:   Thu, 2 Aug 2018 21:08:38 -0300
From:   Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>
To:     Wei Yongjun <weiyongjun1@...wei.com>
Cc:     David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel.vetter@...ll.ch>,
        Gustavo Padovan <gustavo.padovan@...labora.com>,
        Haneen Mohammed <hamohammed.sa@...il.com>,
        dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH -next] drm/vkms: Fix the error handling in vkms_init()

On 08/02, Wei Yongjun wrote:
> In the drm_vblank_init() error handling case, platform device
> unregister is missing. This patch fix it.
> 
> Fixes: 3a0709928b17 ("drm/vkms: Add vblank events simulated by hrtimers")
> Signed-off-by: Wei Yongjun <weiyongjun1@...wei.com>
> ---
>  drivers/gpu/drm/vkms/vkms_drv.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/vkms/vkms_drv.c b/drivers/gpu/drm/vkms/vkms_drv.c
> index 6e728b8..5ad09d4 100644
> --- a/drivers/gpu/drm/vkms/vkms_drv.c
> +++ b/drivers/gpu/drm/vkms/vkms_drv.c
> @@ -110,7 +110,7 @@ static int __init vkms_init(void)
>  	ret = drm_vblank_init(&vkms_device->drm, 1);
>  	if (ret) {
>  		DRM_ERROR("Failed to vblank\n");
> -		goto out_fini;
> +		goto out_unregister;
>  	}
>  
>  	ret = vkms_modeset_init(vkms_device);
>

Hi,

Thanks for the patch! Everything is fine for me.

Reviewed-by: Rodrigo Siqueira <rodrigosiqueiramelo@...il.com>