linux-kernel - Re: [PATCH] mt76x0: build driver only as module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87zhy36c4n.fsf@kamboji.qca.qualcomm.com>
Date:   Fri, 03 Aug 2018 12:19:20 +0300
From:   Kalle Valo <kvalo@...eaurora.org>
To:     Stanislaw Gruszka <sgruszka@...hat.com>
Cc:     Wireless <linux-wireless@...r.kernel.org>,
        Stephen Rothwell <sfr@...b.auug.org.au>,
        Linux-Next Mailing List <linux-next@...r.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mt76x0: build driver only as module

Stanislaw Gruszka <sgruszka@...hat.com> writes:

> There are various symbols that conflicts with mt7601u.
> Due to that kernel will not build with allyesconfig.
> For now limit the driver to be build only as module.
>
> Signed-off-by: Stanislaw Gruszka <sgruszka@...hat.com>

Thanks for the quick patch!

> --- a/drivers/net/wireless/mediatek/mt76/Kconfig
> +++ b/drivers/net/wireless/mediatek/mt76/Kconfig
> @@ -11,7 +11,7 @@ config MT76x2_COMMON
>  
>  config MT76x0U
>  	tristate "MediaTek MT76x0U (USB) support"
> -	depends on MAC80211
> +	depends on MAC80211 && m

But this feels like an ugly hack to me. Isn't there a better way to fix
this? (I don't have time to investigate the error in detail right now.)

-- 
Kalle Valo