linux-kernel - Re: [PATCH v12 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 3 Aug 2018 14:12:50 +0300
From:   Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
To:     lee.jones@...aro.org, robh+dt@...nel.org, mark.rutland@....com,
        eballetbo@...il.com, linus.walleij@...aro.org,
        mazziesaccount@...il.com, dmitry.torokhov@...il.com
Cc:     linux-clk@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, sboyd@...nel.org, broonie@...nel.org,
        linux-input@...r.kernel.org, mikko.mutanen@...rohmeurope.com,
        heikki.haikola@...rohmeurope.com
Subject: Re: [PATCH v12 1/2] mfd: bd71837: mfd driver for ROHM BD71837 PMIC

On Fri, Aug 03, 2018 at 02:08:14PM +0300, Matti Vaittinen wrote:
> ROHM BD71837 PMIC MFD driver providing interrupts and support
> for three subsystems:
> - clk
> - Regulators
> - input/power-key
> 
> Signed-off-by: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>
> Reviewed-by: Enric Balletbo i Serra <enric.balletbo@...labora.com>

I maintained Enric's Reviewed-by as only change I did to v12 was:

> +	ret = regmap_irq_get_virq(bd71837->irq_data, BD71837_INT_PWRBTN_S);
> +
> +	if (ret < 0) {
> +		dev_err(&i2c->dev, "Failed to get the IRQ\n");
> +		return ret;
> +	}
> +
> +	button.irq = ret;

instead of v11 which was:

+       button.irq = regmap_irq_get_virq(bd71837->irq_data,
+                                         BD71837_INT_PWRBTN_S);
+
+       if (button.irq < 0) {
+               dev_err(&i2c->dev, "Failed to get the IRQ\n");
+               return button.irq;
+       }

Br,
	Matti Vaittinen