linux-kernel - Re: [PATCH] lightnvm: pblk: fix rqd.error return value in pblk_blk_erase

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A68E3E50-F18C-464D-8596-A6E269568B1B@cnexlabs.com>
Date:   Fri, 3 Aug 2018 12:25:17 +0000
From:   Javier Gonzalez <javier@...xlabs.com>
To:     Matias Bjørling <mb@...htnvm.io>
CC:     "Konopko, Igor J" <igor.j.konopko@...el.com>,
        "marcin.dziegielewski@...el.com" <marcin.dziegielewski@...el.com>,
        Hans Holmberg <hans.holmberg@...xlabs.com>,
        Heiner Litz <hlitz@...c.edu>,
        Young Tack Tack Jin <youngtack.jin@...cuitblvd.com>,
        "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] lightnvm: pblk: fix rqd.error return value in
 pblk_blk_erase_sync

> On 2 Aug 2018, at 22.50, Matias Bjørling <mb@...htnvm.io> wrote:
> 
> rqd.error is masked by the return value of pblk_submit_io_sync.
> The rqd structure is then passed on to the end_io function, which
> assumes that any error should lead to a chunk being marked
> offline/bad. Since the pblk_submit_io_sync can fail before the
> command is issued to the device, the error value maybe not correspond
> to a media failure, leading to chunks being immaturely retired.
> 
> Also, the pblk_blk_erase_sync function prints an error message in case
> the erase fails. Since the caller prints an error message by itself,
> remove the error message in this function.
> 
> Signed-off-by: Matias Bjørling <mb@...htnvm.io>
> ---
> drivers/lightnvm/pblk-core.c | 19 ++-----------------
> 1 file changed, 2 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/lightnvm/pblk-core.c b/drivers/lightnvm/pblk-core.c
> index 72acf2f6dbd6..814204d22a2e 100644
> --- a/drivers/lightnvm/pblk-core.c
> +++ b/drivers/lightnvm/pblk-core.c
> @@ -886,10 +886,8 @@ static void pblk_setup_e_rq(struct pblk *pblk, struct nvm_rq *rqd,
> 
> static int pblk_blk_erase_sync(struct pblk *pblk, struct ppa_addr ppa)
> {
> -	struct nvm_rq rqd;
> -	int ret = 0;
> -
> -	memset(&rqd, 0, sizeof(struct nvm_rq));
> +	struct nvm_rq rqd = {0};

This is a matter of taste, but if you want to squeeze it in here, it is
fine by me. There are other places with the same pattern; if you feel
strongly about this then please send a patch changing it in all the
places.

> +	int ret;
> 
> 	pblk_setup_e_rq(pblk, &rqd, ppa);
> 
> @@ -897,19 +895,6 @@ static int pblk_blk_erase_sync(struct pblk *pblk, struct ppa_addr ppa)
> 	 * with writes. Thus, there is no need to take the LUN semaphore.
> 	 */
> 	ret = pblk_submit_io_sync(pblk, &rqd);
> -	if (ret) {
> -		struct nvm_tgt_dev *dev = pblk->dev;
> -		struct nvm_geo *geo = &dev->geo;
> -
> -		pblk_err(pblk, "could not sync erase line:%d,blk:%d\n",
> -					pblk_ppa_to_line(ppa),
> -					pblk_ppa_to_pos(geo, ppa));
> -
> -		rqd.error = ret;
> -		goto out;
> -	}
> -
> -out:
> 	rqd.private = pblk;
> 	__pblk_end_io_erase(pblk, &rqd);
> 
> --
> 2.11.0

Otherwise, it looks like a good cleanup. Thanks.

Reviewed-by: Javier González <javier@...xlabs.com>


Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)